[HIGH] Create Trip Details

stitesExpensify commented 6 months ago

VIP-Travel Implementation Issue

Tracking Issue: https://github.com/Expensify/Expensify/issues/333471 Project: https://github.com/orgs/Expensify/projects/112/ Relevant Design Doc Section: https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit#bookmark=id.lgcmthyxnpmx

This issue is for creating a new trip details modal:

A new page, TravelDetails.ts will be created in src/pages/Travel:

It will receive the transactionID as a route parameter, which we’ll use to retrieve the full transaction via withOnyx, and, from there, we’ll display the travel-related information
It will include a HeaderWithBackButton component with either “Flight Details” or “Hotel Details” as the title, depending on whether it is a flight or a hotel booking. Similarly, it will either display a plane or a hotel icon, which we will pass to HeaderWithBackButton through the new parameter added here. - - For other travel-related expenses (Trains, car rental), the title will default to the generic “Travel Details” and the plane icon (we can change this down the line).
The itinerary and confirmation number elements will be displayed using the existing MenuItemWithTopDescription component with the interactive parameter set to false. For the itinerary’s arrow for flights, we can use the ➜ unicode character.
A new component, TripDetailsMenuItem will be created to display the detailed itinerary (with the airline, airports, etc). It will receive the travel-related information from the transaction as a parameter and will be formatted as displayed above. Since the user can’t interact with the element in any way, there is no need for further considerations.
The trip support link will be displayed using the existing MenuItem component, passing our phone icon as the icon. On click, it will take the user to Spotnana’s support page.

Routes table: https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit#bookmark=id.gn6jbl2udlnx

cdOut commented 6 months ago

Hello, I’m Tymoteusz from Software Mansion, the expert agency, and I’d like to work on this task.

twisterdotcom commented 6 months ago

Adding a C+ here for Travel reviews: @shubham1206agra

twisterdotcom commented 6 months ago

Only assigned on Friday. We can give them a day here Melvin.

melvin-bot[bot] commented 6 months ago

@twisterdotcom, @shubham1206agra, @cdOut Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

twisterdotcom commented 6 months ago

Are we waiting on anything internal here?

cdOut commented 5 months ago

No, Im working on creating a draft PR for this issue by tomorrow.

twisterdotcom commented 5 months ago

Nice, draft PR is in!

twisterdotcom commented 5 months ago

Same Q, answer in one place is fine: https://github.com/Expensify/App/issues/37824#issuecomment-2034635911

cdOut commented 5 months ago

@twisterdotcom both PRs are linked, we are currently waiting for the backend implementation, since right now we basically work on dummy data.

From what I know it has been decided that we will hold off on these PRs with further reviews until we get backend access, you can refer to this decision here.

twisterdotcom commented 5 months ago

Still waiting on webhooks.

melvin-bot[bot] commented 5 months ago

@twisterdotcom, @shubham1206agra, @cdOut Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

twisterdotcom commented 5 months ago

Waiting on the backend.

twisterdotcom commented 5 months ago

Waiting on the backend still

twisterdotcom commented 4 months ago

Spotnana thread for backend updates here: https://expensify.slack.com/archives/C066REXJ9D3/p1713220956933639

twisterdotcom commented 4 months ago

Chatting about getting the data here: https://expensify.slack.com/archives/C05S5EV2JTX/p1713784714491629?thread_ts=1713545844.230119&cid=C05S5EV2JTX

melvin-bot[bot] commented 4 months ago

@twisterdotcom, @shubham1206agra, @cdOut Whoops! This issue is 2 days overdue. Let's get this updated quick!

twisterdotcom commented 4 months ago

Update: https://expensify.slack.com/archives/C05S5EV2JTX/p1714085516706139?thread_ts=1713825695.223409&cid=C05S5EV2JTX

melvin-bot[bot] commented 4 months ago

@twisterdotcom, @shubham1206agra, @cdOut Whoops! This issue is 2 days overdue. Let's get this updated quick!

twisterdotcom commented 4 months ago

Update here: https://expensify.slack.com/archives/C05S5EV2JTX/p1714431147318139. Waiting on Spotnana.

twisterdotcom commented 4 months ago

@rushatgabhane any linked draft here yet?

melvin-bot[bot] commented 4 months ago

@twisterdotcom, @rushatgabhane, @shubham1206agra, @cdOut Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 4 months ago

@twisterdotcom, @rushatgabhane, @shubham1206agra, @cdOut Eep! 4 days overdue now. Issues have feelings too...

cdOut commented 4 months ago

@twisterdotcom I'm already back from OOO and I have the most context on this one. Could I take this issue back since it seems like @rushatgabhane is already occupied by other projects?

rushatgabhane commented 4 months ago

@cdOut yes please go ahead! Thank you 🙇‍♂️

twisterdotcom commented 4 months ago

@cdOut I believe you should be able to get going on this now.

cdOut commented 4 months ago

I've replied in this thread.