search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.53k stars 2.88k forks source link

Amount validation is requested on Connect with Plaid after trying to add BA manually #37865

Closed m-natarajan closed 8 months ago

m-natarajan commented 8 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.48-0 Reproducible in staging?: y Reproducible in production?: couldn't check If this was caught during regression testing, add the test name, ID and link from TestRail: n/a Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

Pre-requisite: user must be logged in and have created a workspace.

  1. Go to Workspace > Bank account.
  2. Select Connect manually.
  3. Initiate the add bank account flow with the testing credentials until you reach the "Validate your bank account" page.
  4. Click on the back arrow.
  5. Click on "Start over".
  6. Select Connect online with Plaid.
  7. Select Regions bank and use the testing credentials.
  8. Confirm the account.
  9. Verify you land on "Validate your bank account" page.

Expected Result:

The user should be able to continue with the add BA flow (enter Personal info, Company info, Beneficial owners).

Actual Result:

The user is taken to "Validate your bank account" page after confirming the account.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/38435837/365b89bb-0d90-4b8d-b6b1-01db57d842d7

View all open jobs on GitHub

melvin-bot[bot] commented 8 months ago

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

github-actions[bot] commented 8 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 8 months ago

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

m-natarajan commented 8 months ago

@techievivek FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

MitchExpensify commented 8 months ago

Related? https://github.com/Expensify/App/issues/32356

nkuoch commented 8 months ago

It's a feature, not a bug.

Disconnecting from a policy when in PENDING or OPEN state doesn't remove it from the account anymore. It just detaches it from the policy. So, when re-entering the same bank account, you don't need to redo it all. It just attaches the existing one.

If you actually delete it from your account from your personal settings, you'll have to redo it all, as before.

MitchExpensify commented 8 months ago

@m-natarajan seeing as this is a feature not a bug, do you agree the TR steps need to be updated to avoid this being reported again?