search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

[HOLD for payment 2024-03-19] Tag - Not here page shows up when opening Tag from split details RHP #37886

Closed izarutskaya closed 8 months ago

izarutskaya commented 8 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.48-0 Reproducible in staging?: Y Reproducible in production?: Y Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal Team

Action Performed:

Precondition:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Go to FAB > Split bill > Scan.
  4. Create a split scan request.
  5. Click on the split preview to open split details RHP.
  6. Click Tag.

Expected Result:

Tag list opens without issue.

Actual Result:

Not here page shows up when opening Tag from split details RHP.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/93afc90c-0c48-4739-ab5c-d9dc7102ba69

View all open jobs on GitHub

melvin-bot[bot] commented 8 months ago

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

github-actions[bot] commented 8 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 8 months ago

Current assignee @puneetlath is eligible for the Engineering assigner, not assigning anyone new.

FitseTLT commented 8 months ago

We have already figured out this before it was created and working on it. PR fixing the regression on review stage @puneetlath

izarutskaya commented 8 months ago

@puneetlath I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think that this bug might be related to #wave6-collect-submitters CC @greg-schroeder

luacmartins commented 8 months ago

@FitseTLT do you have a link to the PR?

FitseTLT commented 8 months ago

https://github.com/Expensify/App/pull/37879 👍

roryabraham commented 8 months ago

again I suspect this is NAB because tags are a collect feature and thus need to be enabled with a JS snippet in OldDot, no?

roryabraham commented 8 months ago

anyways, looks like we may have a WIP fix?

ishpaul777 commented 8 months ago

anyways, looks like we may have a WIP fix?

Yep its completed but I have asked @FitseTLT to retest and update videos, otherwise in my testing PR looks goods to CP 👍

puneetlath commented 8 months ago

again I suspect this is NAB because tags are a collect feature and thus need to be enabled with a JS snippet in OldDot, no?

I agree with this. Removing it as a deploy blocker.

puneetlath commented 8 months ago

PR was merged. It's a regression from another PR so no payment is needed here. Closing.

melvin-bot[bot] commented 8 months ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 8 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.50-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-19. :confetti_ball:

melvin-bot[bot] commented 8 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: