search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.3k stars 2.74k forks source link

[No BZ] Set up MiniFlare for local development + external contributors #38072

Open roryabraham opened 6 months ago

roryabraham commented 6 months ago

Coming from this old WN post and this comment...

Problem

We don't currently have an obvious setup to test the CSP locally. As a result, we only ever find CSP issues on staging, and at that point they are deploy blockers.

Solution

Open-source the NewDot CSP(s) and set up MiniFlare for local testing.

melvin-bot[bot] commented 6 months ago

Triggered auto assignment to @puneetlath (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

melvin-bot[bot] commented 6 months ago

:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:

justinpersaud commented 5 months ago

No update yet, working on SMS related issues

justinpersaud commented 5 months ago

Same ☝🏽

mallenexpensify commented 5 months ago

@justinpersaud the BugZero team is adding all E/App issues with the Bug or NewFeature label to a project. This one is kinda lingering. It will surface each week as part of the #expensify-open-source weekly update. Trying to think how best to handle.

  1. Add a BZ and add to a project
  2. Remove NewFeature
  3. Preface title with [No BZ] to denote it's not a normal feature request or bug
  4. Something else.

Any thoughts/preferances?

justinpersaud commented 5 months ago

2 or 3 probably work. This is sort of a long standing issue we've had since basically the inception of NewDot. It's something we should do, and nice to do, but I don't know that it takes priority over one of our upcoming releases or waves.

mallenexpensify commented 5 months ago

Thanks @justinpersaud . I'm torn between 2 and 3 but, I imagine there'll be other instances where it makes sense to have NewFeature without it needing a BZ so I'm going to go with #3. I'll update the SO to state

justinpersaud commented 4 months ago

No update

justinpersaud commented 4 months ago

Same

justinpersaud commented 3 months ago

Nothing new here

roryabraham commented 3 months ago

I managed to get a Miniflare instance running and to work around this issue by prepending the command with NODE_EXTRA_CA_CERTS="" like so:

NODE_EXTRA_CA_CERTS="" npx wrangler dev index.js
justinpersaud commented 3 months ago

No update, fire and comp review taking priority

justinpersaud commented 3 months ago

Same

justinpersaud commented 3 months ago

Still the same

justinpersaud commented 2 months ago

Same

justinpersaud commented 2 months ago

Working on #fast-apis issues right now

justinpersaud commented 1 month ago

@roryabraham is this still valuable to do?

roryabraham commented 1 month ago

yep. There have been a number of CSP issues where we've wanted a way to test it locally, and things have not worked when we tested them on staging. here's a semi-recent example.

roryabraham commented 1 month ago

Going to co-assign so it's in my K2 as well, and I can give it a go next time I have a bit of free time.

justinpersaud commented 1 month ago

nothing new yet

justinpersaud commented 1 month ago

Still the same

justinpersaud commented 3 weeks ago

Ditto

roryabraham commented 1 week ago

no update

roryabraham commented 3 days ago

no update