[HOLD for payment 2024-04-05] [$250] Chats - Expensify / Chats is not aligned on the same line

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.48k stars 2.84k forks source link

[HOLD for payment 2024-04-05] [$250] Chats - Expensify / Chats is not aligned on the same line #38298

Closed lanitochka17 closed 6 months ago

lanitochka17 commented 7 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.52-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Issue found when executing PR https://github.com/Expensify/App/pull/37421

Action Performed:

Go to staging.new.expensify.com
Make sure the workspace filter is Expensify

Expected Result:

Expensify / Chats is aligned on the same line

Actual Result:

Expensify / Chats is not aligned on the same line

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6413173_1710400313627!bandicam_2024-03-14_15-08-37-869

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c8acccc3eea77881
Upwork Job ID: 1768272521223192576
Last Price Increase: 2024-03-14
Automatic offers:

cubuspl42 | Reviewer | 0

cubuspl42 commented 7 months ago

@MahmudjonToraqulov

What about my alternative solution?

I don't interpret the "What alternative solutions did you explore?" section like some other people do. For me, it's an optional section that's best suited for describing rejected solutions.

If you actually want to suggest two different solutions, which you both fully tested and are ready to sign under both, I think you should describe them as "Option A" / "Option B" in the "What changes do you think we should make in order to solve the problem?" section.

In the case of a visual issue like this one, you should provide screenshots for both "Option A" and "Option B".

Since this issue is "suspected" to be platform-specific, I think that screenshots for multiple platforms should be provided. At least iOS Native, Android Native, mobile Web (on minimum one OS), desktop Web (on one browser). You can use the<details> tag like in the template.

aneequeahmad commented 7 months ago

@cubuspl42 here are screenshot of my proposal on different platforms.

iOS Native:

IOS_native

Android native:

Screenshot_20240319-032421

mobile Web (Safari):

mWeb

desktop Web(Mac Os/Chrome):

Screenshot_20240319-165139

cubuspl42 commented 7 months ago

It looks good, as far as I can tell!

I approve the proposal by @aneequeahmad

I base my decision on a mix of simplicity, effectiveness, and the order of submission.

Thanks, everyone!

C+ reviewed 🎀 👀 🎀

melvin-bot[bot] commented 7 months ago

Current assignees @puneetlath and @amyevans are eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

melvin-bot[bot] commented 7 months ago

📣 @cubuspl42 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

melvin-bot[bot] commented 7 months ago

📣 @aneequeahmad You have been assigned to this job! Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing 📖

aneequeahmad commented 7 months ago

@cubuspl42 PR is ready for review

melvin-bot[bot] commented 6 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 6 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.57-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/38891

If no regressions arise, payment will be issued on 2024-04-05. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@cubuspl42 requires payment automatic offer (Reviewer)
@aneequeahmad requires payment (Needs manual offer from BZ)

melvin-bot[bot] commented 6 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@cubuspl42] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@cubuspl42] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@cubuspl42] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@cubuspl42] Determine if we should create a regression test for this bug.
[ ] [@cubuspl42] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

puneetlath commented 6 months ago

@cubuspl42 friendly reminder on the checklist so that we can pay tomorrow.

cubuspl42 commented 6 months ago

The PR that introduced the bug has been identified. Link to the PR:
- https://github.com/Expensify/App/pull/32221
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- https://github.com/Expensify/App/pull/32221#issuecomment-2039306743
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- No need for additional discussion
Determine if we should create a regression test for this bug.
- No
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- N/A

puneetlath commented 6 months ago

@cubuspl42 has been paid.

@aneequeahmad I sent you an offer here. Ping me on this issue when you've accepted.

aneequeahmad commented 6 months ago

@puneetlath I have accepted the offer. Thank you for mentioning

aneequeahmad commented 6 months ago

@puneetlath Friendly reminder

puneetlath commented 6 months ago

Everyone has been paid. Thanks y'all!