Closed mountiny closed 8 months ago
Job added to Upwork: https://www.upwork.com/jobs/~013d991bde7ae0309e
Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal
)
Triggered auto assignment to @joekaufmanexpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
@mountiny is the only PR here the web PR, meaning there's no contributor's involved?
correct this is done, can close, thank you
The Newdot taxes API needs couple of changes as found by @kosmydel working on the UI parts:
SetPolicyTaxesEnabled
we can have multiple taxes enabled at the same time so the param needs to be JSONARRAY not a single JSONOBJECTDeletePolicyTaxes
command expects a list of names of taxes and not a list of taxCodes as the param name suggests which is confusingRenamePolicyTax
, there is no validation for already existing tax namesLets fix these items
Upwork Automation - Do Not Edit