Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.33k stars 2.76k forks source link

[HOLD for payment 2024-07-17][$500] Move "Troubleshoot" out of About and into Settings as its own nav item #38594

Closed shawnborton closed 1 month ago

shawnborton commented 5 months ago

We want to take the Troubleshoot page: CleanShot 2024-03-19 at 10 19 04@2x

And move it into the Settings navigation as it's own nav item, right above the Sign Out option at the bottom. When doing this, the Troubleshoot UI should look like the About page, where we use the card style and a nice header with an illustration + h2: image

cc @TMisiukiewicz since I think you originally implemented this? This would just be a follow up to that.

cc @muttmuure @Expensify/design

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01928d4373947e3fe3
  • Upwork Job ID: 1770771675763638272
  • Last Price Increase: 2024-03-28
  • Automatic offers:
    • alitoshmatov | Reviewer | 0
    • tienifr | Contributor | 0
Issue OwnerCurrent Issue Owner: @muttmuure
tienifr commented 4 months ago

@alitoshmatov The follow-up PR is ready https://github.com/Expensify/App/pull/40822

melvin-bot[bot] commented 4 months ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

danieldoglas commented 4 months ago

@tienifr can you confirm if this is really related? https://github.com/Expensify/App/issues/41275

alitoshmatov commented 4 months ago

@tienifr can you confirm if this is really related? https://github.com/Expensify/App/issues/41275

This is not related

shawnborton commented 4 months ago

@tienifr what is the latest with adjusting the illustration position as a follow up?

melvin-bot[bot] commented 3 months ago

This issue has not been updated in over 15 days. @danieldoglas, @muttmuure, @alitoshmatov, @tienifr eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

dannymcclain commented 3 months ago

What's going on with this one? Is it done?

Screenshot from desktop staging app: CleanShot 2024-05-27 at 09 41 59@2x

shawnborton commented 3 months ago

We still have an outstanding regression that needs to be taken care of, take a look at this comment

dannymcclain commented 3 months ago

Ah I see! Thanks! I see the follow-up PR for that is in the works.

melvin-bot[bot] commented 3 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 3 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.81-11 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-18. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 3 months ago

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

melvin-bot[bot] commented 3 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.82-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-20. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 3 months ago

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

alitoshmatov commented 2 months ago

Regression Test Proposal

  1. Go to settings
  2. Check Troubleshoot menu item is there in general section after About menu item
  3. Click on Troubleshoot
  4. Check that the page is exactly like given in the design guidelines
  5. Make sure everything in Troubleshoot page is working in all platforms

Do we agree 👍 or 👎

alitoshmatov commented 2 months ago

@muttmuure This one is ready for payment

shawnborton commented 2 months ago

I found another regression with this one: the Troubleshoot page uses white/light text for the status bar text, and thus you can't see the status bar on iOS: CleanShot 2024-06-19 at 15 55 01@2x

@tienifr @alitoshmatov can you have a look at that please? Thanks!

tienifr commented 2 months ago

@shawnborton We will update it to something like below, right?

image

shawnborton commented 2 months ago

Exactly, check every other page in Settings and you will see the expected behavior.

tienifr commented 2 months ago

@alitoshmatov PR https://github.com/Expensify/App/pull/44048 to fix https://github.com/Expensify/App/issues/38594#issuecomment-2178784914 can be reviewed

alitoshmatov commented 2 months ago

https://github.com/Expensify/App/pull/44048 PR was merged and now on staging

melvin-bot[bot] commented 2 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 2 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.5-13 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-17. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 2 months ago

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

melvin-bot[bot] commented 2 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.6-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-22. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 2 months ago

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

alitoshmatov commented 1 month ago

Regression test is here

alitoshmatov commented 1 month ago

Regression period ends on 17th, pr was merged on 10th

muttmuure commented 1 month ago

$500 - @alitoshmatov $500 - @tienifr

muttmuure commented 1 month ago

Paid