Closed shawnborton closed 1 month ago
@alitoshmatov The follow-up PR is ready https://github.com/Expensify/App/pull/40822
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
@tienifr can you confirm if this is really related? https://github.com/Expensify/App/issues/41275
@tienifr can you confirm if this is really related? https://github.com/Expensify/App/issues/41275
This is not related
@tienifr what is the latest with adjusting the illustration position as a follow up?
This issue has not been updated in over 15 days. @danieldoglas, @muttmuure, @alitoshmatov, @tienifr eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
What's going on with this one? Is it done?
Screenshot from desktop staging app:
We still have an outstanding regression that needs to be taken care of, take a look at this comment
Ah I see! Thanks! I see the follow-up PR for that is in the works.
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.81-11 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-18. :confetti_ball:
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.82-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-20. :confetti_ball:
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Troubleshoot
menu item is there in general section after About
menu itemTroubleshoot
Troubleshoot
page is working in all platformsDo we agree 👍 or 👎
@muttmuure This one is ready for payment
I found another regression with this one: the Troubleshoot page uses white/light text for the status bar text, and thus you can't see the status bar on iOS:
@tienifr @alitoshmatov can you have a look at that please? Thanks!
@shawnborton We will update it to something like below, right?
Exactly, check every other page in Settings and you will see the expected behavior.
@alitoshmatov PR https://github.com/Expensify/App/pull/44048 to fix https://github.com/Expensify/App/issues/38594#issuecomment-2178784914 can be reviewed
https://github.com/Expensify/App/pull/44048 PR was merged and now on staging
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.5-13 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-17. :confetti_ball:
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.6-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-22. :confetti_ball:
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Regression test is here
Regression period ends on 17th, pr was merged on 10th
$500 - @alitoshmatov $500 - @tienifr
Paid
We want to take the Troubleshoot page:
And move it into the Settings navigation as it's own nav item, right above the Sign Out option at the bottom. When doing this, the Troubleshoot UI should look like the About page, where we use the card style and a nice header with an illustration + h2:
cc @TMisiukiewicz since I think you originally implemented this? This would just be a follow up to that.
cc @muttmuure @Expensify/design
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @muttmuure