Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

2.97k stars 2.48k forks source link

[HOLD for payment 2024-04-25] [TS migration] Migrate StepScreenWrapper and StepScreenDragAndDropWrapper components to TypeScript #38913

Closed fabioh8010 closed 1 week ago

fabioh8010 commented 1 month ago

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

src/pages/iou/request/step/StepScreenWrapper.js
src/pages/iou/request/step/StepScreenDragAndDropWrapper.js

fabioh8010 commented 1 month ago

This issue is internal and will be handled by the TS team.

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

BrtqKr commented 1 month ago

Hey, I'm from SWM, I'd like to take over this issue

stephanieelliott commented 1 month ago

Thanks @BrtqKr! You're assigned 😊

stephanieelliott commented 1 month ago

Hey @BrtqKr, any update on when this PR will be taken out of draft state?

BrtqKr commented 4 weeks ago

@stephanieelliott Friday morning probably, I've already applied review fixes from the cross-review, so we're close. Sorry for the delay, but I combined it with IOU screens and the second part was a bit more troublesome than I initially expected

stephanieelliott commented 4 weeks ago

No worries @BrtqKr, thanks for the update!

stephanieelliott commented 2 weeks ago

PR is on staging

melvin-bot[bot] commented 2 weeks ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 2 weeks ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.62-17 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/39175

If no regressions arise, payment will be issued on 2024-04-25. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@BrtqKr does not require payment (Contractor)

melvin-bot[bot] commented 2 weeks ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [] The PR that introduced the bug has been identified. Link to the PR:
[ ] [] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@BrtqKr] Determine if we should create a regression test for this bug.
[ ] [@BrtqKr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

stephanieelliott commented 1 week ago

Reapplying the Bug label to get another BZ member on this while I am OOO til May 2. Thanks @CortneyOfstad, only thing to do here is issue payment on 4/25!

melvin-bot[bot] commented 1 week ago

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

CortneyOfstad commented 1 week ago

We're all good! Closing this out!