search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.05k stars 2.57k forks source link

[TS Migration] Adjust eslint config, TS config #39119

Open mountiny opened 2 months ago

mountiny commented 2 months ago

Follow up issue for TS migration project. Coming from this spreadsheet

Błażej: Remove JS specific rules, merge some of them, disallow JS in TS Config, needs investigation

Also adjust https://typescript-eslint.io/rules/no-unused-vars/ Eslint rule to allow unused arguments starting with underscore

cc @blazejkustra @fabioh8010

Issue OwnerCurrent Issue Owner: @bfitzexpensify
blazejkustra commented 1 month ago

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

blazejkustra commented 1 month ago

Update: I was sick last week, I'm aiming to have a PR ready for review tomorrow.

blazejkustra commented 1 month ago

Draft PR is up! cc @fabioh8010

war-in commented 1 month ago

We've decided to remove eslint rules in separate PR because of a huge amount of TS errors (check @blazejkustra's comment). I'll take care of it

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @bfitzexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

parasharrajat commented 1 month ago

I was C+ on the PR.

bgawkuc commented 2 weeks ago

Hi, as @blazejkustra and @war-in mentioned we'd like to split it into smaller PRs. I'd like to work on enabling no-unsafe-call eslint rule

mountiny commented 2 weeks ago

Thanks, please go ahead

melvin-bot[bot] commented 2 weeks ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 2 weeks ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.76-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-05. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 2 weeks ago

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

blazejkustra commented 2 weeks ago

Update: We are still working on removal of these rules:

        '@typescript-eslint/no-unsafe-call': 'off',
        '@typescript-eslint/no-unsafe-member-access': 'off',
        '@typescript-eslint/no-unsafe-assignment': 'off',

@bgawkuc will post a draft PR today for the no-unsafe-call rule

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @trjExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

bfitzexpensify commented 2 weeks ago

Adding a BZ buddy - I will be OOO until June 11th

melvin-bot[bot] commented 1 week ago

Payment Summary

[Upwork Job]()

BugZero Checklist (@trjExpensify)

trjExpensify commented 1 week ago

Alright, so just confirming the payment summary is as follows:

$250 to @parasharrajat for the C+ review.

Let me know if that's correct, and then I'll close and Rajat can submit an expense!

blazejkustra commented 1 week ago

@bgawkuc is working on enabling three more ESLint rules as part of this issue (here is one ongoing PR). For some reason @parasharrajat wasn't assigned to it :/

parasharrajat commented 1 week ago

Let's hold the payment for now. There will be more PRs.

trjExpensify commented 6 days ago

Oh okay.

bgawkuc commented 2 days ago

Update: