Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.33k stars 2.76k forks source link

[$250] IOU - RBR appears then disappears from IOU preview component & LHN #39174

Closed kbecciv closed 6 days ago

kbecciv commented 5 months ago

If you havenโ€™t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.57-2 Reproducible in staging?: y Reproducible in production?: y Issue found when executing PR: https://github.com/Expensify/App/pull/37875 Issue reported by: Applause - Internal team

Action Performed:

  1. On the main device, create an IOU with secondary device user
  2. On the secondary device, settle the payment
  3. On the main device, make a second request right after secondary device settles the request

Expected Result:

RBR should remain on IOU preview component, and LHN of the main report until it is cleared

Actual Result:

RBR fades away from IOU preview component, and LHN after few seconds

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/0840c8a9-8991-45f9-8067-02c6fa8ffb93

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0162848aad35917395
  • Upwork Job ID: 1776390018885652480
  • Last Price Increase: 2024-09-04
melvin-bot[bot] commented 5 months ago

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

kbecciv commented 5 months ago

We think that this bug might be related to #wave-collect - Release 1

kbecciv commented 5 months ago

@kevinksullivan I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

kevinksullivan commented 5 months ago

This wold go in split, so I'll add it to that project and push forward.

melvin-bot[bot] commented 5 months ago

Job added to Upwork: https://www.upwork.com/jobs/~0162848aad35917395

melvin-bot[bot] commented 5 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

VickyStash commented 5 months ago

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

VickyStash commented 5 months ago

I did some investigations, and that's what I've found out. The reason for RBR disappearing with the described flow is that the money request is turned into settled and the app doesn't show RBR for settled money requests. https://github.com/Expensify/App/blob/4f673576491af54296014b7595e6ad5017fdb60e/src/components/ReportActionItem/ReportPreview.tsx#L216 This logic was implemented as a requirement for this issue in the related PR.

Overall it looks like expected behavior, but if we want to define more specific cases when we want to show RBR indicators for settled money requests we need to know the requirements.

melvin-bot[bot] commented 5 months ago

@kevinksullivan, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 5 months ago

@kevinksullivan @getusha this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 5 months ago

@kevinksullivan, @getusha Eep! 4 days overdue now. Issues have feelings too...

kevinksullivan commented 5 months ago

@getusha since you are working on another project should we reassign this?

getusha commented 5 months ago

Overall it looks like expected behavior, but if we want to define more specific cases when we want to show RBR indicators for settled money requests we need to know the requirements.

@kevinksullivan, @VickyStash is suggesting that this is an expected behavior. cc @aldo-expensify @c3024 @abdulrahuman5196 for confirmation.

melvin-bot[bot] commented 5 months ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] commented 5 months ago

@kevinksullivan, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 5 months ago

@kevinksullivan, @getusha Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] commented 4 months ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

kevinksullivan commented 4 months ago

asking about this bug in slack

https://expensify.slack.com/archives/C05RECHFBEW/p1713548212648119

melvin-bot[bot] commented 4 months ago

@kevinksullivan, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 4 months ago

@kevinksullivan, @getusha Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 4 months ago

@kevinksullivan @getusha this issue is now 4 weeks old, please consider:

Thanks!

melvin-bot[bot] commented 4 months ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] commented 4 months ago

@kevinksullivan, @getusha 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] commented 4 months ago

@kevinksullivan, @getusha 10 days overdue. Is anyone even seeing these? Hello?

kevinksullivan commented 4 months ago

following up in slack

https://expensify.slack.com/archives/C05RECHFBEW/p1714516535693249?thread_ts=1713548212.648119&cid=C05RECHFBEW

melvin-bot[bot] commented 4 months ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] commented 4 months ago

@kevinksullivan, @getusha 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] commented 4 months ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] commented 4 months ago

@kevinksullivan, @getusha 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

melvin-bot[bot] commented 4 months ago

@kevinksullivan, @getusha 12 days overdue. Walking. Toward. The. Light...

melvin-bot[bot] commented 4 months ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] commented 4 months ago

This issue has not been updated in over 14 days. @kevinksullivan, @getusha eroding to Weekly issue.

melvin-bot[bot] commented 3 months ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] commented 3 months ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] commented 3 months ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] commented 3 months ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] commented 2 months ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] commented 2 months ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] commented 2 months ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

luacmartins commented 2 months ago

Maybe we can increase the bounty on this one since we don't have proposals?

mvtglobally commented 2 months ago

Issue not reproducible during KI retests. (First week)

melvin-bot[bot] commented 2 months ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] commented 1 month ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

kevinksullivan commented 1 month ago

closing as not reproducible.

m-natarajan commented 1 month ago

@kevinksullivan Tester is still reproducible. On main parent report RBR is not appearing on IOU preview component and main report LHN. The RBR persist only in combined report and thread report.

https://github.com/user-attachments/assets/c52d13a5-b0c0-4c68-baab-392559a8946e

melvin-bot[bot] commented 1 month ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] commented 1 month ago

@kevinksullivan, @getusha Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 1 month ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] commented 1 month ago

@kevinksullivan, @getusha 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] commented 1 month ago

@kevinksullivan, @getusha 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!