search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.95k stars 2.46k forks source link

Android - Infinite skeleton flickering when open report with deleted expense #39185

Closed kbecciv closed 2 weeks ago

kbecciv commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.57-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4459012&group_by=cases:section_id&group_order=asc&group_id=296773 Issue reported by: Applause - Internal Team

Action Performed:

Precondition: User is employee 1 of Collect workspace Steps:

  1. Login to OldDot with the employee 1 account
  2. Navigate to workspaces and set the collect policy to default if not already set
  3. Navigate to reports
  4. Create a report
  5. Add expense to the report
  6. As employee on new dot verify that report is visible
  7. Go to Old Dot> Delete the expense from the report
  8. As employee on new dot open the same report

Expected Result:

The report conversation doesn't display the expense that was removed

Actual Result:

The report conversation page on new dot shows Infinite skeleton flickering when delete the expense from old dot

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/1567014e-fa4b-40fc-967a-71b065c37cf6

View all open jobs on GitHub

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

kbecciv commented 1 month ago

@JmillsExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

kbecciv commented 1 month ago

We think that this bug might be related to #wave-collect - Release 1

JmillsExpensify commented 3 weeks ago

@trjExpensify You're closer to this than me. Will this be fixed as part of our backward compatibility initiatives?

trjExpensify commented 3 weeks ago

Strange that it's Android specific, is that right? Anyway, I think unreporting and deleting expenses is being worked on here: https://github.com/Expensify/Expensify/issues/364642

CC: @madmax330

melvin-bot[bot] commented 2 weeks ago

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

JmillsExpensify commented 2 weeks ago

Agreed. I'm going to close for now and let's re-assess when backward compatibility is addressed.