Closed lanitochka17 closed 6 months ago
Triggered auto assignment to @JmillsExpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #vip-vsp
@JmillsExpensify Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
Visual but worth fixing. Adding to #wave-collect
Job added to Upwork: https://www.upwork.com/jobs/~0140f5a4dbf368b480
Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External
)
WS Categories - A space gap is displayed for a moment on the list after category deletion
In the file, WorkspaceCategoriesPage.tsx
, I think when we delete a category list then it takes time to get updated.
I think we can add this code,
const updatedList = categoryList.filter(c => c.name !== deletedCategoryName)
setCategoryList(updatedList)
what it will do is - When deleting a category, immediately update the categoryList
state by filtering out the deleted category. This will remove it from the list optimistically before the API request finishes.
N/A
WS Categories - A space gap is displayed for a moment on the list after category deletion
In TableListItem.tsx
, containerStyle
of BaseListItem
has been added with styles.mb3
3 weeks ago.
It's happening this bug that shows a gap space of mb3
while deleting a category.
We can move this mb3
style to pressableStyle
instead of containerStyle
n/a
📣 @solar-dev23! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Contributor details Your Expensify account email: solar.dev023@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~018b3dcfc2c45fda08
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
Not reproducible, probably fixed by https://github.com/Expensify/App/pull/39226
https://github.com/Expensify/App/assets/59907218/3cdfbc18-414b-49be-8162-b5c483d5116c
Not reproducible, probably fixed by #39226
Screen.Recording.2024-04-12.at.11.01.36.PM.mov
This is the correct PR )
@JmillsExpensify @alitoshmatov this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
We can close this issue
@JmillsExpensify, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
Thanks, closing.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.58-4 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4466254 Email or phone of affected tester (no customers): applausetester+vd_ios032924@applause.expensifail.com Issue reported by: Applause - Internal Team
Action Performed:
Pre-requisite: the user must be logged in and have created a collect workspace
Expected Result:
There should be no space gap displayed after category deletion
Actual Result:
A space gap is displayed for a moment after category deletion
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/ceed34b6-fea8-4ebe-ab1b-f9f2c42cce44
View all open jobs on GitHub
Upwork Automation - Do Not Edit