Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.51k stars 2.86k forks source link

[HOLD for payment 2024-04-25] [$500] Chats are not loading in the LHN with `Most Recent` mode #39380

Closed m-natarajan closed 6 months ago

m-natarajan commented 7 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): @iwiznia Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @iwiznia Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1711986719647329

Action Performed:

  1. Open any app with most recent set

Expected Result:

LHN should be loaded with all the chats

Actual Result:

seeing just one chat in staging in my LHN but there should be a lot more chats in there

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

image (1)

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01baee4a02953c567d
  • Upwork Job ID: 1777435508308942848
  • Last Price Increase: 2024-04-08
melvin-bot[bot] commented 7 months ago

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 7 months ago

Triggered auto assignment to @hayata-suenaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

MelvinBot commented 7 months ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

github-actions[bot] commented 7 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
marcaaron commented 7 months ago

@hayata-suenaga can you try to check logs for @iwiznia and see if anything is happening?

This might not need to be an App deploy blocker and could be a Web deploy issue.

Sounds like a backend issue. What do you think?

Looks like there's more context in this thread: https://expensify.slack.com/archives/C049HHMV9SM/p1711986719647329

hayata-suenaga commented 7 months ago

Might be from OpenApp.

Checking this log right now

hayata-suenaga commented 7 months ago

from this log search

Expensify\AppInit - OpenApp returned 2 reports ~~ mostRecentReportActionLastModified: '2024-04-01 15:38:44.892' enablePriorityModeFilter: ''
Expensify\AppInit - OpenApp returned 1 reports ~~ mostRecentReportActionLastModified: '2024-04-01 14:49:31.353' enablePriorityModeFilter: ''

Seems like the timing of these logs aligns with the timing when Ionatan experienced the issue.

hayata-suenaga commented 7 months ago

the most recent changes to OpenApp on Auth is 2 weeks ago: https://github.com/Expensify/Auth/blame/main/auth/command/OpenApp.cpp

iwiznia commented 7 months ago

This is an API bug https://expensify.slack.com/archives/C049HHMV9SM/p1712010668902339?thread_ts=1711986719.647329&cid=C049HHMV9SM so maybe we should close this or move it to the other repo (but we can also keep it here)

hayata-suenaga commented 7 months ago

fire room update

CortneyOfstad commented 7 months ago

PR update here from fire room 👍

However, issue is still on-going — Data Dump thread here

CortneyOfstad commented 6 months ago

@hayata-suenaga there doesn't seem to be any updates in the Fire Room for this — can you provide an update on where we're at any any potential next steps? Thanks!

hayata-suenaga commented 6 months ago

Thank you for keeping an eye on this, Cortney. I'll check if there has been a new deployment and update on it here today 😄

melvin-bot[bot] commented 6 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01baee4a02953c567d

melvin-bot[bot] commented 6 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

hayata-suenaga commented 6 months ago

I'll mark this issue as external in case a cause is on the front end. As this is the fire issue, I'll increase the bounty to $500.

melvin-bot[bot] commented 6 months ago

Upwork job price has been updated to $500

eh2077 commented 6 months ago

This issue doesn't require C+, so I'll unassign myself.

melvin-bot[bot] commented 6 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 6 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.62-17 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-25. :confetti_ball:

melvin-bot[bot] commented 6 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

mvtglobally commented 6 months ago

Issue not reproducible during KI retests. (First week)

hayata-suenaga commented 6 months ago

The issue was fixed in this PR. I'm going to write a PM soon. Closing this issue