search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.03k stars 2.54k forks source link

[$500] Attachment - 'New message' button appears when deleting attachment #39421

Closed izarutskaya closed 3 weeks ago

izarutskaya commented 2 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.59-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4468722 Email or phone of affected tester (no customers): natnael.expensify+3@gmail.com Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

  1. Navigate to a report has multiple chat
  2. Send attachment
  3. Delete the attachment
  4. Click on 'New messages' button

Expected Result:

'New messages' button shouldn't appear, and attachment should remain deleted

Actual Result:

'New messages' button appears, and attachment reappear when clicking 'New messages' button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/6830f6a6-bef6-4715-bdaf-8fde3bd6ceb7

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010fcec62910c073e7
  • Upwork Job ID: 1775234083431460864
  • Last Price Increase: 2024-04-30
  • Automatic offers:
    • jjcoffee | Reviewer | 0
    • c3024 | Contributor | 0
melvin-bot[bot] commented 1 month ago

Current assignee @deetergp is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

bernhardoj commented 1 month ago

Looks like the selected solution is the same as in my PR here

melvin-bot[bot] commented 1 month ago

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

melvin-bot[bot] commented 1 month ago

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

jjcoffee commented 1 month ago

Looks like the selected solution is the same as in my PR here

@bernhardoj Thanks for the heads up! Hmm I'm not sure what we'd normally do in this situation. This issue is older so it would normally take precedence, but the other issue is also not a straight dupe of this one...

jjcoffee commented 4 weeks ago

Just a heads up I'll be OOO 6-13th (I may have some time on the 6th), so this may need to be reassigned depending on what is decided to do here. cc @garrettmknight

kaushiktd commented 3 weeks ago

@garrettmknight I pulled latest code and this issue appears to be fixed!

melvin-bot[bot] commented 3 weeks ago

@deetergp, @garrettmknight, @jjcoffee, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

deetergp commented 3 weeks ago

I asked for a re-test here https://expensify.slack.com/archives/C9YU7BX5M/p1715052903386669

kavimuru commented 3 weeks ago

Issue is fixed.

https://github.com/Expensify/App/assets/43996225/c07e6d4a-393c-4371-9093-fa04fad8e74a

deetergp commented 3 weeks ago

@garrettmknight I think we can close this one out.

deetergp commented 3 weeks ago

Is there anything we need to do before closing this one @garrettmknight?

garrettmknight commented 3 weeks ago

Just reviewing - doesn't look like we got a PR up or anything so I'm going to just close since this was fixed elsewhere.