[HOLD][$250] Android - Chat - Sending code block message with italic is not applied& preview inconsistent

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.60 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4478250 Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap on a report
3. Enter |||
4. Launch app
5. Tap on a report
6. Enter |||
7. Note the difference in preview in mweb and app
8. Send the message
9. Note italic markdown not applied

Expected Result:

Code block with italic preview must not be inconsistent in mweb and Android. Sending code block message with italic must be applied in Android

Actual Result:

Code block with italic preview is inconsistent in mweb and Android. Sending code block message with italic is not applied in Android

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/03504c85-9b50-4416-8f86-024f7bdaee3e

View all open jobs on GitHub

[bernhardoj]

I think you forgot to apply this:

fontFamily: FontUtils.fontFamily.platform.MONOSPACE.fontFamily,

[hoangzinh]

Thanks @bernhardoj. @bernhardoj proposal looks good to me

Link to proposal https://github.com/Expensify/App/issues/39623#issuecomment-2039459978

🎀👀🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @NikkiWines, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[NikkiWines]

Yep, looks good 👍

[bernhardoj]

So, what's the process for getting the new font file? We need specifically:

1. ExpensiMono-Italic
2. ExpensiMono-BoldItalic

[hoangzinh]

Hi @Expensify/design, currently our App only have font ExpensiMono-Regular and ExpensiMono-Bold. We're looking for fonts below in order to fix this issue:

• ExpensiMono-Italic
• ExpensiMono-BoldItalic

They look like our custom fonts. Do our team have those missing fonts? Thanks in advance.

[dannymcclain]

Looking through our font files, I don't believe we have any Italic versions of Expensify Mono.

[dubielzyk-expensify]

Makes me wonder if we should check with the type foundry to see if this is something we'd wanna add. I'll add it to the list to discuss, but for now we don't have any.

[hoangzinh]

Thanks, @dubielzyk-expensify and @dannymcclain. I think, for now, we can mark this issue as Hold On while waiting Design team to discuss whether we want to add those fonts in our App.

[dannymcclain]

Sounds good. For something like this I'd prefer to wait until Shawn is back and can weigh in anyways.

[isabelastisser]

Moving to weekly until @shawnborton is back.

[shawnborton]

Hey, I'm back! We don't have our mono fonts in italic styles... but we could definitely ask for them!

Let me reach out to our font foundry and get their opinion. Will cc the @Expensify/design team.

[shawnborton]

Okay, we're going to get some updated Expensify Mono Italic font files for this, but we likely won't have them for quite some time (December?). So we might want to put a HOLD on this issue for the time being and come back to it once we actually have the new font files raedy for use.

[bernhardoj]

Thanks for the update! Just to confirm, are we getting both Mono Italic and Mono Italic Bold font files?

[shawnborton]

Yup, we'll get both of those files in all formats we could need (.otf, .woff, etc)

[bernhardoj]

Nice, thanks for the confirmation!

[NikkiWines]

Updating this issue to reflect that we'll be waiting a bit to get the updated fonts ⏰