Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.99k stars 2.5k forks source link

[Awaiting Payment 16th May] [Wave Collect] [Xero] Handle errors in the connections #39726

Closed lakchote closed 2 days ago

lakchote commented 1 month ago

We need to handle Xero connection errors. More details here.

This will be worked on by SWM engineers, see Slack discussion here.

Until the Xero authorization flow (NewDot issue) is done (which entails NewDot, Web-E and IS changes), we won't be able to work on this yet.

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @sonialiap (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

sonialiap commented 1 month ago

On hold for https://github.com/Expensify/App/issues/39725

lakchote commented 4 weeks ago

Double-checking with internal engineers, some might be interested to work on this.

SzymczakJ commented 3 weeks ago

I can take care of that, since I'm already in context because I was doing Xero authorization flow. Could you assign me @mountiny?

hayata-suenaga commented 3 weeks ago

@lakchote thank you for handling this. I have one question:

Is this about the error handling when connecting to Xero or error handling for invalid configuration combinations?

or is it about error handling for sync errors?

mountiny commented 3 weeks ago

I think this is purely the connection errors

lakchote commented 2 weeks ago

I think this is purely the connection errors

Yes @hayata-suenaga, as @mountiny said it's purely showing the connection errors and the RBR.

sonialiap commented 2 weeks ago

On hold for https://github.com/Expensify/App/issues/39725

lakchote commented 2 weeks ago

Not on hold anymore, cc @SzymczakJ

lakchote commented 1 week ago

Assigning @mananjadhav as he'll be working on this.

mananjadhav commented 1 week ago

@lakchote Added the PR to fix the disconnect Xero.

trjExpensify commented 1 week ago

Deployed to prod 9 hours ago.

mananjadhav commented 5 days ago

Payout for this will be handled after all Xero issues are done. We can close this after the regression period.

trjExpensify commented 2 days ago

Yep, agreed. Regression period is over, closing.