[HOLD #8267] Web - Read messages are marked unread after a while

isagoico commented 3 years ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open an unread chat
Navigate to other chats and use the app for a little while

Expected Result:

Unread chat should stay marked as unread.

Actual Result:

The chat that was opened earlier is marked as unread. Explained by @iwiznia:

I can't reliably reproduce this, but happens several times a day in web. I get a new message, I read it, come back later and the message is back to unread.

Workaround:

None needed. It's just confusing to the user to see a chat marked as unread when it was opened before.

Platform:

Where is this issue occurring?

Web ✔️ iOS Android Desktop App ✔️ Mobile Web

Version Number: 1.0.77-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

I haven't been able to reproduce this yet on my side. Will update here if I find any more information about this.

Expensify/Expensify Issue URL:

View all open jobs on Upwork

From @iwiznia https://expensify.slack.com/archives/C01GTK53T8Q/p1626078601100700

I can't reliably reproduce this, but happens several times a day in web. I get a new message, I read it, come back later and the message is back to unread.

MelvinBot commented 3 years ago

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

MelvinBot commented 3 years ago

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

jboniface commented 3 years ago

Since this hasn't been reproduced, I am hesitant to post the job

isagoico commented 3 years ago

Looks like @tgolen @stitesExpensify and @cead22 were able to reproduce this issue too 🤔 @iwiznia I know this is a long shot but I have some questions that could help me get solid repro steps:

Do you have an estimate of how much time it passes from reading the message to the unread status?
Are there other tabs opened with e.cash active? Or other devices logged in with the same account that were being used at the same time?
Does this happen with the same chat each time or are several chats affected?

cead22 commented 3 years ago

@iwiznia also check that you don't have policy rooms with unread messages (eg, #announce) -- Cole let me know recently that this could be another cause of 3.cash showing the unread indicator

tgolen commented 3 years ago

Do you have an estimate of how much time it passes from reading the message to the unread status?

For me, it seems to happen more often when I go to the e.cash tab, sit for 1-2 seconds (and read the most recent message), then go to another tab quickly. I suspect this is the cause of the issue.

Are there other tabs opened with e.cash active? Or other devices logged in with the same account that were being used at the same time?

There should only be one tab open when it's happened to me. I very rarely use mobile and web at the same time, so I don't think this would be the cause of it.

Does this happen with the same chat each time or are several chats affected?

It's always one chat affected at a time, but not always the same chat, no.

On Mon, Jul 12, 2021 at 4:25 PM Carlos Alvarez @.***> wrote:

@iwiznia https://github.com/iwiznia also check that you don't have policy rooms with unread messages (eg, #announce) -- Cole let me know recently that this could be another cause of 3.cash showing the unread indicator

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Expensify/Expensify.cash/issues/3981#issuecomment-878638603, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJMAB2VWKW3PT757XBXWKDTXNTW5ANCNFSM5AHEFDCQ .

iwiznia commented 3 years ago

Do you have an estimate of how much time it passes from reading the message to the unread status?

It varies, I don't think the time is a determining factor here.

Are there other tabs opened with e.cash active? Or other devices logged in with the same account that were being used at the same time?

Nope

Does this happen with the same chat each time or are several chats affected?

Same as Tim, only one at a time, but not the same one each time

@iwiznia also check that you don't have policy rooms with unread messages (eg, #announce) -- Cole let me know recently that this could be another cause of 3.cash showing the unread indicator

Already did, this is not it. If it was, then the unread would not go away when I re-read the chat

isagoico commented 3 years ago

Thanks for the extra info! 🙇 No luck yet on being able to repro the issue yet. Will update if I find something.

isagoico commented 3 years ago

@puneetlath Had this same behaviour with his own message: (slack link here https://expensify.slack.com/archives/C01GTK53T8Q/p1626387107365600)

I have no idea how to reproduce this, but sometimes when I come back to the app after being away from my computer, my own messages will be marked unread. For example, this was a message that I sent to Tom a little earlier

isagoico commented 3 years ago

@joaniew was able to reproduce this too (slack thread: https://expensify.slack.com/archives/C01GTK53T8Q/p16263903423766000)

sometimes messages will get randomly marked as unread (on iOS mobile) even if they’ve been read previously on either mobile or web

iwiznia commented 3 years ago

Yep, I get that too seemingly randomly, not even sure if I need to go away for it to happen, I think not.

MelvinBot commented 3 years ago

@thienlnam Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

thienlnam commented 3 years ago

Still having trouble getting consistent reproduction steps for this - with how random it is maybe it has to do with having instances on other devices and an older set of data overwriting the newer data

thienlnam commented 3 years ago

Throwing on a weekly until we can get better reproduction steps

thienlnam commented 3 years ago

No proposals or clear re-production steps yet

thienlnam commented 3 years ago

Could I get a thumbs up / thumbs down reaction if people are still experiencing this? Seeing if we can close out this issue

isagoico commented 3 years ago

I didn't get a screenshot but I was able to reproduce this yesterday on Web

iwiznia commented 3 years ago

This happens to me every day at least once (but usually more)

puneetlath commented 3 years ago

Same, I'm still frequently experiencing it.

arielgreen commented 3 years ago

I'm going to throw External back on here so we can get this posted. Even if it's just to have a contributor investigate.. Seems like a lot of us are still experiencing this, evidenced in this issue and here and here.

MelvinBot commented 3 years ago

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

mallenexpensify commented 3 years ago

This happens to me on Desktop as well, updated OP with a ✔️

Since TRJ is outta office I assigned to myself to post, only for Upwork to not allow me to post :(

MelvinBot commented 3 years ago

Triggered auto assignment to @johnmlee101 (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

mallenexpensify commented 3 years ago

Posted to Upwork https://www.upwork.com/jobs/~01ccc3f953f511f8e8 note, we've had trouble gathering reliable reproduction steps, so that might be the best place to start

johnmlee101 commented 3 years ago

If someone has this happen to them, please post with the steps you took beforehand!

twisterdotcom commented 3 years ago

Seems like maybe @sophiepintoraetz can recreate it with Chronos? https://expensify.slack.com/archives/CC7NECV4L/p1630547590050700?thread_ts=1630536076.046400&cid=CC7NECV4L

AndrewGable commented 3 years ago

I can too, it only happens with Chronos for me.

sophiepintoraetz commented 3 years ago

Okay, going to see if I can catch it today. Sent my 10am to Chronos at 7:39am NZT (N.B. this is earlier than I would normally do my 10am - sometimes it's past 10am) To be crystal clear, the steps I took are:

Write 10am
Press enter to send it
Wait in the chat to receive confirmation from Chronos
Receive message, note that it is read as Chronos is unbolded in the LHN chat scroller
Navigate to another chat - note that red bubble and bold text is not present, indicating that message has been read
Two hours later, Chronos is marked as unread again

sophiepintoraetz commented 3 years ago

Okay, this is weird, I've already received an email, indicating that I haven't read it - though I have

sophiepintoraetz commented 3 years ago

I got it!! It's essentially two hours later.

mallenexpensify commented 3 years ago

Gonna kick this rock down the road...

mallenexpensify commented 3 years ago

Possibly related.... I occasionally send a user a message then THAT same message will show as unread in LHN, even though I was the one to send and the user hasn't replied.

mallenexpensify commented 3 years ago

Just happened to me - I closed the lid on my comp (macbook pro) to put it to sleep, opened it up 5-10 mins later, noticed a message that I sent to Jeremy yesterday was highlighted as unread.

sophiepintoraetz commented 3 years ago

Yeah this is still occurring on a regular basis for me.

mallenexpensify commented 3 years ago

@sophiepintoraetz (who I still think is in a different time zone), when it happens again, can you see if it might be related to closing or putting your comp to sleep? or.. when it wakes up? Thanks

michaelhaxhiu commented 3 years ago

Not overdue, still on hold!

Any chance of discerning the cause for this issue @sophiepintoraetz? (i.e. whether the issue is caused by closing laptop or putting it to sleep)?

isagoico commented 3 years ago

@rafecolton Is experiencing this issue more recently - https://expensify.slack.com/archives/C01GTK53T8Q/p1633566684464000

mallenexpensify commented 3 years ago

Not overdue

mallenexpensify commented 3 years ago

I was able to reproduce by switching the wifi on my comp from my home network to tethering from my phone, a chat in LHN, with a message I sent to Jeremy, was bolded. @isagoico can you test to see if you're able to reproduce using my method?

isagoico commented 3 years ago

mm I'm not able to reproduce following these steps:

Send a message
Just as the message is received on the other account change wifi to mobile network hotspot
Wait for a bit

Also tried:

Send a message
Navigate to another conversation
Changed to mobile network
Wait for a little bit

Still not able to reproduce 😟

mallenexpensify commented 3 years ago

@isagoico were you using the below steps (or similar) for replicating unstable internet?

Turn on mobile internet on phone.
Turn on hotspot/internet sharing on your phone.
Connect your laptop/pc to the network shared from mobile.
Now enable/disable mobile internet in the phone, I find this is easiest to simulate connection drop.

isagoico commented 3 years ago

Yep, I dropped the connection by disabling mobile data in several scenarios (when the message is sending, after the message is sent and before sending the message.. tried to be creative here with different flows) but was unable to reproduce. @mallenexpensify Are you able to reproduce consistently?

I have been able to reproduce this issue on my side but without solid reproduction steps, it seems to happen randomly from time to time.

mallenexpensify commented 3 years ago

Just tried to reproduce but couldn't. One weird thing, my chat with Jeremy which showed as unread earlier when it shouldn't have, completely disappeared from the top of LHN for a while (20 seconds?) where it should have been (1. cuz new message, 2. cuz I owe him $10MM apparently)

mallenexpensify commented 3 years ago

n6-hold is lifted, label removed! Doubled price of job to $500, Posted in Slack to offer to pay $500 for someone who can document reproducible steps where we (QA and internal) are able to reliably reproduce the bug. https://www.upwork.com/jobs/~01c4c544f32e8892ce

Santhosh-Sellavel commented 3 years ago

cc: @mallenexpensify @isagoico I was able to reproduce this easily in the Desktop app. ~(I'll check and update the same in Web)~ Able to reproduce same on the web also using below steps.

Steps to Reproduce:

Open the New Expensify app on the desktop/web.
Go to Chronos Chat (Replies Immediately)
Try to set reminders using 10am: Reminder
Chronos reply messages are marked as read.
Quit and Open the app/(web browser). (When I restart my PC in Mac It will be still reproducible)
In LHN Still shows "Choronus chats as marked unread."

Before Quitting the app:

After Reopen:

kidroca commented 3 years ago

I think this comment and ticket are relevant here: https://github.com/Expensify/App/issues/4273#issuecomment-920845714

It seem strange that in the past this would happen multiple times a day for people, but now it would only happen with Chronos

The Chronos one seems to be a separate issue, while the more prominent issue might have been solved by the shared ticket

Rooms like Chonos and Concierge are handled differently so it might be a special case there I don't have access to Chronos to investigate further

mallenexpensify commented 3 years ago

This can happen for me on any/all messages, def NOT specific to Chronos. We're looking for reliably reproducible steps for any chat.

My hunch is it has to do with connecting/disconnecting because I've experienced while switching from wifi from home > mobile tethering and also when closing my laptop and reopening (often sometime late, not immediately)

isagoico commented 3 years ago

I was able to reproduce the Chronos issue on my side but I have definitely experienced this with other conversations. I'll post here if I find more on how to reproduce this consistently.

Santhosh-Sellavel commented 3 years ago

After going through all other this issue comments. I only see two issues discussed here

Read the message marked as unread. I faced this issue only with Chronos only so far even it occurred a few times to me earlier not just today. Also, I see only evidently (Screenshots) it occurred for Chronos only in this issue comments & mentioned slack threads. Also, just noticed @sophiepintoraetz gave the steps to reproduce here
https://github.com/Expensify/App/issues/3981#issuecomment-912000926

Also, she mentioned being able to capture after 2 hours here https://github.com/Expensify/App/issues/3981#issuecomment-912071613

But no need to wait so long just close the browser then reopen we can get reproduce the issue quickly.
Own messages marked as unread. - based on other screenshots. For this we have a related issue here #5405

This can happen for me on any/all messages, def NOT specific to Chronos. We're looking for reliably reproducible steps for any chat.

I agree might but the fix provided for Chronos should address for all other chats also because Chronos is also a chat only.

cc: @mallenexpensify

Also, I'll look to reproduce the issue for other chats also.

mallenexpensify commented 3 years ago

@Santhosh-Sellavel , can you see if you can reliably reproduce with non-Chronos chats? And if so, document the steps to do so? Thanks

Expensify / App