Closed trjExpensify closed 4 months ago
Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.
Hey, I can take care of this tomorrow.
Add the percentage of the rate to the table on the Taxes page in the workspace settings.
New feature
if (taxID === defaultExternalID && taxID === foreignTaxDefault) {
return `• ${translate('common.default')}`;
}
if (taxID === defaultExternalID) {
return `• ${translate('workspace.taxes.workspaceDefault')}`;
}
if (taxID === foreignTaxDefault) {
return `• ${translate('workspace.taxes.foreignDefault')}`;
}
${value.value} ${textForDefault(key)}
Assigning @rojiphil for the C+ review.
Triggered auto assignment to @neil-marcellini, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
This issue has not been updated in over 15 days. @rojiphil, @trjExpensify, @neil-marcellini, @kosmydel eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Cool, sounds good!
Payment summary as follows:
$250 to @rojiphil for the C+ review
Offer sent in Upwork!
Offer sent in Upwork!
Accepted offer. Thanks
Paid!
Coming from this thread.
Problem: The table of rates don't include the rate percentage, only the name. As a result, an admin is forced to click into each one in the table to figure out that information, which is extraneous on this page and makes it feel cumbersome to use.
Solution: Add the percentage rate in the supporting text line before "Default", "Workspace currency default" and "Foreign currency default", separated by a dot separator when applicable.
Jakub from SWM is going to create a PR for this, I've pinged him in the thread to reply on this issue so we can assign it to him.
CC: @JmillsExpensify @shawnborton @twisterdotcom