Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.33k stars 2.76k forks source link

Add support for Descriptions in Group Chats #40312

Closed marcaaron closed 1 week ago

marcaaron commented 5 months ago

Coming from https://expensify.slack.com/archives/C05RECHFBEW/p1712957571237659

Problem

When we implemented Group Chats we did not give the ability to add a Description. This is largely do to the fact that we undertook a large migration of Group DMs over to Group Chats and are now harmonizing these two similar designs (Rooms & Groups).

Solution

When this ticket is done we should have the ability to add a Description to a "Group Chat" at creation and also update that description from the "Report Details" page.

Image

Additionally, we should have the ability to create a description at the time when a Group Chat is created.

And lastly, we should ensure that:

Image

Image

Subject: # [inviter] invited you to [RoomTitle] Body: [RoomDescription]

Backend changes:

I'd suggest we follow the existing pattern of reusing any possible code from Auth related to Rooms. In this case, the commands would be:

CreatePolicyRoom and UpdateRoomDescription. We create Group chats when calling OpenReport so reusing CreatePolicyRoom directly would be incorrect here.

Frontend changes:

Once we can support Group chat descriptions in the backend we can open this up to a contributor to wire up the UI changes and API.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01472e1c18fbc629f5
  • Upwork Job ID: 1780332023202934784
  • Last Price Increase: 2024-04-16
melvin-bot[bot] commented 5 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01472e1c18fbc629f5

melvin-bot[bot] commented 5 months ago

Triggered auto assignment to @isabelastisser (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

melvin-bot[bot] commented 5 months ago

:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:

melvin-bot[bot] commented 5 months ago

Triggered auto assignment to Contributor Plus for review of internal employee PR - @c3024 (Internal)

isabelastisser commented 4 months ago

Waiting for engineering assignment.

isabelastisser commented 4 months ago

Not overdue.

JmillsExpensify commented 4 months ago

@isabelastisser I'm going to take this one on, if you don't mind. Trying to get a handle on what remains for the group chat implementation.

JmillsExpensify commented 3 months ago

Still in the queue for group chats.

JmillsExpensify commented 3 months ago

Still in the queue.

JmillsExpensify commented 3 months ago

Same.

JmillsExpensify commented 2 months ago

Not a priority

JmillsExpensify commented 2 months ago

Not a priority.

JmillsExpensify commented 1 month ago

Still not a priority