search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.4k stars 2.79k forks source link

[HOLD for payment 2024-06-05] Fix notification preferences for Group Chats so they are "immediate" instead of "hidden" #40314

Open marcaaron opened 5 months ago

marcaaron commented 5 months ago

Coming from https://expensify.slack.com/archives/C05RECHFBEW/p1712957522045629

Problem

When we implemented Group Chats we followed the existing pattern for our Group DMs where all users start with a notificationPreference of 'hidden' on the chat. This optimization existed so that any empty chats would not show up for users without any content in their LHN.

However, upon reflection we have decided that this should behave closer to the existing "Rooms" behavior. Additionally, since we are adding descriptions to Group Chats this will help contextualize the experience for any invited users (see: https://github.com/Expensify/App/issues/40312).

Solution

This will be an entirely backend change for the most part. We need to change the logic here when creating a Group Chat.

And numerous tests.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0163fccf2efd233395
  • Upwork Job ID: 1780335646090248192
  • Last Price Increase: 2024-04-16
melvin-bot[bot] commented 5 months ago

Job added to Upwork: https://www.upwork.com/jobs/~0163fccf2efd233395

melvin-bot[bot] commented 5 months ago

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

marcaaron commented 5 months ago

Since this is a backend issue I'm gonna remove @Santhosh-Sellavel

srikarparsi commented 5 months ago

Will do this this week.

JmillsExpensify commented 4 months ago

Any progress on this one?

srikarparsi commented 4 months ago

Sorry, haven't been able to work on this but will get at least a draft PR and hopefully a full PR out tomorrow.

saracouto commented 4 months ago

@srikarparsi are you working on this? The status is unassigned right now so I want to make sure it is categorized correctly!

srikarparsi commented 4 months ago

Hey! Yeah I am, have both PRs up, the Auth one still needs a little work to get the tests to pass. I think ETA is Thursday or Friday.

melvin-bot[bot] commented 4 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 4 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.76-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-05. :confetti_ball:

melvin-bot[bot] commented 3 months ago

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

situchan commented 3 months ago

Please assign me here

srikarparsi commented 3 months ago

Assigning @situchan for reviewing this PR. I still have to work on the Auth PR to finish this issue. I'm trying to finish this issue this week so will probably get to finishing the Auth PR next week.

srikarparsi commented 3 months ago

Have not yet got to finishing the App PR because I'm still working on closed/archived. I'll try to fit in sometime towards the end of this week to work on this.

srikarparsi commented 3 months ago

^ I think it's looking more like beginning of next week now. I'm also assigned an Improve Performance of Authenticate Issues which is fast-apis so I'm doing that, then closed/archived and then this.

srikarparsi commented 3 months ago

Same as above, maybe will get to it Wednesday/Thursday

srikarparsi commented 3 months ago

Still haven't had time because of closed/archived work and fast-apis. I'll try to finish those things up next week so that I can get to this.

srikarparsi commented 3 months ago

Same update as above, will try to look into this Thursday or Friday. @marcaaron I don't believe this is done yet? I can move it back to In progress on the project board unless there's a different reason you moved it to Done.

marcaaron commented 3 months ago

Oh sorry, I move anything with a HOLD for payment into the "Done" just for my own personal tracking purposes on this stuff.

srikarparsi commented 3 months ago

Same update as above, I'm working on fast-apis and wave-collect currently. I'm going to move this back to a weekly if that's okay.

srikarparsi commented 2 months ago

No update, still focussed on wave-collect and fast-apis

srikarparsi commented 1 month ago

Tests are failing. (I accidentally commented about a different PR in this PR 2 weeks ago)

srikarparsi commented 1 month ago

No update this week. Will try to get to this during onshore.

srikarparsi commented 1 month ago

No update yet

srikarparsi commented 1 month ago

No update yet. I should be able to get to this next week

srikarparsi commented 2 weeks ago

Focussed on other priorities

srikarparsi commented 3 days ago

No update