search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.96k stars 2.47k forks source link

[$250] Clicking into a thread and out disappears message below the parent message #40376

Closed m-natarajan closed 1 week ago

m-natarajan commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.62-14 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @johnmlee101 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713370130959229

Action Performed:

  1. Open any report
  2. Click to the thread
  3. Click on the the header to return back to the message

Expected Result:

Should be taken back into the chat report. The URL shouldn't contain the messageID.

Actual Result:

Taken to just the parent chat message. URL has the messageID appended to it.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/38435837/9988761f-5168-4e8f-9daa-70ee22c7e239

https://github.com/Expensify/App/assets/38435837/854ecd44-e002-4e1a-a0d8-b2d2a4df5ce5

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01dc0dcd6e681f7ef2
  • Upwork Job ID: 1780701535328817152
  • Last Price Increase: 2024-04-17
melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 1 week ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
sakluger commented 1 week ago

Yeah this is a legit deploy blocker! Adding external label for help finding out where it broke.

melvin-bot[bot] commented 1 week ago

Job added to Upwork: https://www.upwork.com/jobs/~01dc0dcd6e681f7ef2

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

rushatgabhane commented 1 week ago

Tested on latest main branch, the bug isn't reproducible.

https://github.com/Expensify/App/assets/29673073/2304e4f4-bdf1-469c-9a72-b90c90d923a3

QichenZhu commented 1 week ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

The URL of the parent link in a thread header contains parentReportActionID.

What is the root cause of that problem?

The parentReportActionID in the URL is used to direct users back to the specific message in the parent and highlight that message.

This feature/bug was first introduced in this commit, and revised a few times later on. The current version is: https://github.com/Expensify/App/blob/3ba42e684f75f143d6e7a85e62d23b7d561d7155/src/components/ParentNavigationSubtitle.tsx#L42

What changes do you think we should make in order to solve the problem?

If it's considered as a feature, leave it as it is.

If it's considered as a bug, revert it to its original version: https://github.com/Expensify/App/blob/610ce2667f7b4104ecb157a8c399249a15ff91cf/src/components/ParentNavigationSubtitle.tsx#L31

What alternative solutions did you explore? (Optional)

N/A

srikarparsi commented 1 week ago

Hey @chiragsalian, do you think you could take a look at this? I think this is expected behavior from this but just want to make sure.

When you click the parent report in the header of a thread, the message id should be in the url right?

rayane-djouah commented 1 week ago

Bug not reproducible on latest main:

https://github.com/Expensify/App/assets/77965000/253233ae-f05a-4645-8432-d3ed2f4c89c8

thienlnam commented 1 week ago

https://github.com/Expensify/App/assets/30609178/4ce731d9-943a-4821-8c23-d5d889b5756b

Also seems to be fixed on staging

aldo-expensify commented 1 week ago

I think this reappeared here: https://github.com/Expensify/App/issues/40644