Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.1k stars 2.6k forks source link

[$250] Workspace - mweb - Invited members disappears from workspace members list #40459

Open m-natarajan opened 2 months ago

m-natarajan commented 2 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.63-0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: n/a Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

  1. Create a workspace
  2. Create a public room
  3. Invite a new member (without an Expensify account)
  4. Observe the member appearing momentarily and then disappearing
  5. Refresh the page and observe the newly invited member on the member list

Expected Result:

Members list should show invited workspace members

Actual Result:

Invited members disappears from workspace members list

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/38435837/45d3975b-eaa0-4a79-9dc6-ee14ef534c0f

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ae90bdc30dbfece7
  • Upwork Job ID: 1781241687789658112
  • Last Price Increase: 2024-06-28
melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 2 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
m-natarajan commented 2 months ago

@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

youssef-lr commented 2 months ago

Investigating

melvin-bot[bot] commented 2 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01ae90bdc30dbfece7

mountiny commented 2 months ago

Making this external to get proposals in

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

ZhenjaHorbach commented 2 months ago

Looks like BE issue We do not receive a login (email) which we use for showing elements

Снимок экрана 2024-04-19 в 11 04 57
youssef-lr commented 2 months ago

@ZhenjaHorbach have you managed to reproduce this? I can't seem to be able to on mWeb iOS nor web, will test in an hour in Android

ZhenjaHorbach commented 2 months ago

I tested in browser ) It always reproduced for me

ZhenjaHorbach commented 2 months ago

But it's strange I just tried to reproduce And I can't do it anymore

youssef-lr commented 2 months ago

Same, I reproduced this only once but never again

thienlnam commented 2 months ago

Going to demote since we're having trouble reproducing this

bfitzexpensify commented 2 months ago

Just noting here - this has been an issue for a while, and was first reported in https://github.com/Expensify/App/issues/36378.

There are details in https://github.com/Expensify/App/issues/36378#issuecomment-1965357368 as to the cause. I'll close https://github.com/Expensify/App/issues/36378 in favour of this since this has been assigned internally.

brunovjk commented 2 months ago

I'm working on PR:Allow anyone to be added/removed to the workspace chat via the Invite/Remove and I'm having the same issue: https://github.com/Expensify/App/issues/35391#issuecomment-2054202715.

I believe this issue is also related.

CortneyOfstad commented 2 months ago

Thanks @brunovjk!

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

mallenexpensify commented 2 months ago

@mollfpr reassigning, please take over as C+. If you don't have bandwidth, unassign yourself. Thanks

CortneyOfstad commented 2 months ago

Thanks @mallenexpensify 👍

Any questions, just let me know @mollfpr!

brunovjk commented 2 months ago

I can no longer reproduce.

"I think this should have been fixed in https://github.com/Expensify/Web-Expensify/pull/41771"

melvin-bot[bot] commented 2 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

mollfpr commented 2 months ago

Sorry for the delay 🙏

I also can't reproduce the issue. I think we can ask QA to test again and close this.

CortneyOfstad commented 2 months ago

Sounds good @mollfpr!

CortneyOfstad commented 2 months ago

Not overdue — waiting for this to be tested 👍

melvin-bot[bot] commented 2 months ago

@youssef-lr @CortneyOfstad @mollfpr this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

brunovjk commented 2 months ago

@CortneyOfstad I can still reproduce by following these steps #36378

melvin-bot[bot] commented 2 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

CortneyOfstad commented 1 month ago

Okay, thanks @brunovjk! Will continue to wait for proposals 👍

Also, I updated the steps in the original GH comment

mvtglobally commented 1 month ago

Issue not reproducible during KI retests. (First week)

CortneyOfstad commented 1 month ago

@mvtglobally — can you confirm you're following the steps outlined here?

CortneyOfstad commented 1 month ago

Bump @mvtglobally on the comment above ^^^

Thanks!

melvin-bot[bot] commented 1 month ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

CortneyOfstad commented 1 month ago

@brunovjk are you still able to recreate this? I am not able to recreate this, and neither is @mvtglobally.

brunovjk commented 1 month ago

@CortneyOfstad Unfortunately yes. For unknown user on public rooms:

Version: v1.4.73-1; Date: 05/13; https://github.com/Expensify/App/assets/95647348/b90cf35e-ca12-438a-a51e-f7de1476957c
youssef-lr commented 1 month ago

Hmm seems like we only applied the fix to workspace members page? The recording above seems to be happening in rooms. We can probably apply the same fix here.

melvin-bot[bot] commented 1 month ago

@youssef-lr @CortneyOfstad @mollfpr this issue is now 4 weeks old, please consider:

Thanks!

melvin-bot[bot] commented 1 month ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

CortneyOfstad commented 1 month ago

Not overdue, still waiting on proposals

CortneyOfstad commented 1 month ago

Posted in Open Source to get some eyes on this (link)

b4s36t4 commented 1 month ago

I think this issue is related to BE, after inviting the user to room BE is not sending the personalDetailsList Onyx value where it does sending for workspace.

Screenshot 2024-05-22 at 8 31 47 PM
melvin-bot[bot] commented 1 month ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 1 month ago

@youssef-lr, @CortneyOfstad, @mollfpr Eep! 4 days overdue now. Issues have feelings too...

CortneyOfstad commented 1 month ago

@youssef-lr can you confirm if this is BE based on the comment here?

melvin-bot[bot] commented 1 month ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 1 month ago

@youssef-lr, @CortneyOfstad, @mollfpr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

CortneyOfstad commented 4 weeks ago

@youssef-lr bump on the question here. Thanks!

youssef-lr commented 3 weeks ago

Will take a look, I'm guessing that yes this is probably BE related.

CortneyOfstad commented 3 weeks ago

Thanks @youssef-lr — any update?

melvin-bot[bot] commented 3 weeks ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸