Closed m-natarajan closed 4 months ago
Triggered auto assignment to @jasperhuangg (DeployBlockerCash
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
Triggered auto assignment to @miljakljajic (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
@miljakljajic FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
We think this bug might be related to #vip-vsb
We think this bug might be related to #vip-vsb
@jasperhuangg what do you think - definitely a deploy blocker? I think this could be worked on externally, right?
Seems like a pretty minor bug and doesn't need to be a blocker
It looks like something that wasn't taken into consideration in https://github.com/Expensify/App/pull/40200, I think we should get the author of the PR to fix this @bernhardoj
I don't think we need to treat this as a regression from https://github.com/Expensify/App/issues/39496 (so we don't need to dock pay), since it wasn't originally included in the requirements for the issue it was solving https://github.com/Expensify/App/issues/39496. But I think @bernhardoj should still fix it for the sake of consistency across all types of links.
Job added to Upwork: https://www.upwork.com/jobs/~01a44464a57aff770b
Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External
)
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External
)
@eh2077 reassigning, please take over as C+. If you don't have bandwidth, unassign yourself. Thanks. I see Reviewing
here but unsure what the linked PR is
@mallenexpensify this is a missing case from my PR, so we are handling it here
@bernhardoj Can you also link this issue in PR https://github.com/Expensify/App/pull/40625? So that we can track this issue together.
Unassign myself since the fix PR https://github.com/Expensify/App/pull/40625 is already ongoing.
Done
@miljakljajic, @jasperhuangg Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@miljakljajic, @jasperhuangg Huh... This is 4 days overdue. Who can take care of this?
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.63-0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: n/a Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:
Action Performed:
Expected Result:
In Step 5, the single line link in the system message will be underlined. In Step 8, right clicking on the link in the system message will invoke "Copy URL to clipboard" option.
Actual Result:
In Step 5, the single line link in the system message is not underlined. In Step 8. right clicking on the link in the system message invoke context menu for the entire system message, instead of "Copy URL to clipboard" option for the link.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/e2bd6cfa-cfb5-4105-959a-958ed9dc2950
View all open jobs on GitHub
Upwork Automation - Do Not Edit