Open gijoe0295 opened 1 month ago
@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@s77rt Initial testing and performance comparison seems promising. Ready for your review.
@gijoe0295 Any update on the use of onyxSubscribe
?
@gijoe0295 Any updates on this?
@gijoe0295 What is the status of this PR? Can you please finish it up?
Details
Remove exported
getReport
.Fixed Issues
$ https://github.com/Expensify/App/issues/40316 PROPOSAL: https://github.com/Expensify/App/issues/40316#issuecomment-2059982364
Tests
Offline tests
NA
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/153004152/9df6a593-9f6f-4d4e-8d24-2c0b2873bbfcAndroid: mWeb Chrome
![Screenshot_1713729984](https://github.com/Expensify/App/assets/153004152/83940a3b-c621-4a50-860f-0fafa30fbea9)iOS: Native
https://github.com/Expensify/App/assets/153004152/19e9e4e8-f1ba-4f6d-8b37-4c00ae2a068a https://github.com/Expensify/App/assets/153004152/01266a48-f562-4132-93ce-c1c1aa752e61iOS: mWeb Safari
https://github.com/Expensify/App/assets/153004152/200982fc-3c24-4a63-93ff-6e3222ec8657MacOS: Chrome / Safari
![Screenshot 2024-04-22 at 02 26 07](https://github.com/Expensify/App/assets/153004152/6fdfc8f1-27cc-45df-8172-cfa938840205) ![Screenshot 2024-04-22 at 02 39 43](https://github.com/Expensify/App/assets/153004152/052317c8-145f-4f90-bf6b-04c4de476733) ![Screenshot 2024-04-22 at 02 40 42](https://github.com/Expensify/App/assets/153004152/b078dc04-f2ef-41de-a054-9b703b65cee3) ![Screenshot 2024-04-22 at 02 43 41](https://github.com/Expensify/App/assets/153004152/e221897d-4dae-46f1-891e-f91658a95cbb) ![Screenshot 2024-04-22 at 02 48 05](https://github.com/Expensify/App/assets/153004152/9ea32005-def6-4307-9157-cf3f8d213967) ![Screenshot 2024-04-22 at 02 49 08](https://github.com/Expensify/App/assets/153004152/58205ffd-f245-40b2-a164-f04d52453592) ![Screenshot 2024-04-22 at 02 49 44](https://github.com/Expensify/App/assets/153004152/1af60393-8005-491f-b119-7a6aa9dd8ffb)MacOS: Desktop
https://github.com/Expensify/App/assets/153004152/8015b3d7-7b43-4c72-a19a-3a4877b4627b