search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.98k stars 2.49k forks source link

[$250] Onboarding- By pulling vertically, user is able to dismiss iOS Onboarding #40555

Open kavimuru opened 2 weeks ago

kavimuru commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.63-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

  1. Access New Expensify iOS app

  2. Sign into a valid account

  3. Go to Settings > Troubleshoot > Onboarding flow to open the modal

  4. Pull down vertically (Right under the status bar)

    Expected Result:

    User expects two thing:

  5. If the user SHOULD be able to dismiss this modal, they should be able to do so via swiping horizontally as in all other parts of the app (Not vertically)

  6. According to the PR, this modal should NOT be able to be closed at all , therefore pulling or swiping horizontally or vertically should not toggle any action

Actual Result:

The modal can be dismissed by pulling down vertically, while the modal on screen slides off the screen horizontally. To be able to dismiss the modal, user should pull down directly under the status bar on the top of the device screen.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/43996225/ddec0fb0-0c44-4b47-bd78-cb2c43829e61

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c66b77d9e4afbb5b
  • Upwork Job ID: 1785060015292096512
  • Last Price Increase: 2024-05-07
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

kavimuru commented 2 weeks ago

@MitchExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

mountiny commented 2 weeks ago

@cdOut @filip-solecki can you please comment here so I can assign you, you have been looking into this one before

melvin-bot[bot] commented 2 weeks ago

@MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

cdOut commented 2 weeks ago

Hi, I’m Tymoteusz Kałuzieński from Software Mansion, the expert agency, and I’d like to work on this task.

MitchExpensify commented 1 week ago

How is the PR coming along @cdOut ?

cdOut commented 1 week ago

I was testing my solutions on native devices and web today, I should have the PR up early next week and push it fast through the review process.

melvin-bot[bot] commented 1 week ago

@mountiny, @MitchExpensify, @cdOut Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

MitchExpensify commented 1 week ago

Checking in on the PR @cdOut 🙇

cdOut commented 1 week ago

I had to reprioritize due to Filip and Jakub both being OOO and I had to overtake some more important tasks from the Xero flow, I will try to work on this one tomorrow.

mountiny commented 1 week ago

Lets make this external

melvin-bot[bot] commented 1 week ago

Job added to Upwork: https://www.upwork.com/jobs/~01c66b77d9e4afbb5b

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

cdOut commented 1 week ago

@mountiny agreed, I won't be able to work on this before being out of office due to the xero and travel tasks. Thank you!

melvin-bot[bot] commented 4 days ago

@parasharrajat @mountiny @MitchExpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 4 days ago

@parasharrajat, @mountiny, @MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

parasharrajat commented 2 days ago

No proposals.

melvin-bot[bot] commented 1 day ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

rezkiy37 commented 1 day ago

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

rezkiy37 commented 1 day ago

Seems like the bug was introduced in this PR. I am an author. So I am fixing the bug like a regression.

parasharrajat commented 1 day ago

Great. Please tag this issue so that I am assigned as reviewer.

🎀 👀 🎀 C+ reviewed

melvin-bot[bot] commented 1 day ago

Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

rezkiy37 commented 1 day ago

Just opened a draft PR. I am opening for review soon 🙂