search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.48k stars 2.84k forks source link

[HOLD #38338][$250] IOU - Deleted IOU request report starts blinking with not found when return online #40705

Closed izarutskaya closed 2 weeks ago

izarutskaya commented 6 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.63-13 Reproducible in staging?: Y Reproducible in production?: N Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

Preconditions: 2 users are logged in Expensify via web and desktop.

  1. Web user: requests money from desktop user
  2. Desktop user: go offline
  3. Desktop user: open IOU report and tap 'Pay elsewhere'
  4. Web user: delete money request
  5. Desktop user: go online

Expected Result:

The deleted IOU should not disappear for desktop user. RBR appear when user go online.

Actual Result:

The deleted IOU not disappear for desktop user. RBR appear when user go online. 'Hm.. it' s not here' start blinking in IOU report.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/04827b83-6aaf-4d7e-8fe8-5e4af3f92a13

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0110d03c8ecb36a282
  • Upwork Job ID: 1782435687211196416
  • Last Price Increase: 2024-06-25
melvin-bot[bot] commented 6 months ago

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 6 months ago

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 6 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
izarutskaya commented 6 months ago

@strepanier03 I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

izarutskaya commented 6 months ago

We think this issue might be related to the #vip-vsb.

mountiny commented 6 months ago

I believe this is not a blocker anymore as we have just deployed

mountiny commented 6 months ago

@izarutskaya @kavimuru can you please retest on latest staging and production to confirm this is a blocker?

melvin-bot[bot] commented 6 months ago

Job added to Upwork: https://www.upwork.com/jobs/~0110d03c8ecb36a282

melvin-bot[bot] commented 6 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

mountiny commented 6 months ago

This was repro in 1.4.63-13 based on the OP so going to remove the deploy blocker label as this version is current production.

Looking for proposals

proverbed commented 5 months ago

I'm unable to reproduce this issue.

melvin-bot[bot] commented 5 months ago

📣 @proverbed! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format: 
    Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
proverbed commented 5 months ago

Contributor details Your Expensify account email: dmitriwarren@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~01a6a5c1a5c91b87e1

melvin-bot[bot] commented 5 months ago

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

strepanier03 commented 5 months ago

Unable to test this today but it's on my todo for tomorrow.

melvin-bot[bot] commented 5 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

strepanier03 commented 5 months ago

I was able to test this but could not reproduce the behavior either.

However, when my desktop user comes online, the deleted expense is removed entirely and there is no RBR either.

strepanier03 commented 5 months ago

Still unable to repro so added label and requested retest.

MelvinBot commented 5 months ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

melvin-bot[bot] commented 5 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

strepanier03 commented 5 months ago

Setting to weekly during retesting.

melvin-bot[bot] commented 5 months ago

@flodnv, @strepanier03, @c3024 Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 5 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

mvtglobally commented 5 months ago

Issue is reproducible during KI retests.

https://github.com/Expensify/App/assets/43995119/264c17fa-f575-4050-8c2c-a2e5b668f381

melvin-bot[bot] commented 5 months ago

@flodnv @strepanier03 @c3024 this issue is now 4 weeks old, please consider:

Thanks!

melvin-bot[bot] commented 5 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

strepanier03 commented 4 months ago

Thank you @mvtglobally!

melvin-bot[bot] commented 4 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 4 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 4 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

mallenexpensify commented 4 months ago

@c3024 , can you take a look at

Repro steps are near identical. Can you review that issue and comment here or there with any thoughts? Normally we'd keep the older issue open but it looks like both these have quite a few comments (and no suggested proposals). At a minimum, I think, we should bump this up to $500 since the other is.

melvin-bot[bot] commented 4 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

c3024 commented 4 months ago

@mallenexpensify

The blinking part is not reproducible any more.

In my opinion this behaviour of disappearing of the deleted request on going online is fine and need not be fixed.

I checked both the issues. Backend sends the response for deleting the request.

https://github.com/Expensify/App/assets/102477862/a0233892-28b0-41da-865d-6821755360db

So, if we need to fix this, this needs to be Internal.

mallenexpensify commented 4 months ago

@flodnv think we should make it internal or close it?

flodnv commented 3 months ago

I got lost in this very old issue, can someone please restate the latest problem statement as experienced by the end user?

melvin-bot[bot] commented 3 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

mallenexpensify commented 3 months ago

Putting this on hold pending

mallenexpensify commented 1 month ago

Still holding

mallenexpensify commented 2 weeks ago

Closing as we're closing #vip-split