search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.48k stars 2.83k forks source link

[HOLD for payment 2024-06-06] 2FA - Web - Infinite loading spinner on 2FA authentication page #40742

Closed kavimuru closed 5 months ago

kavimuru commented 5 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.64-0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4500402&group_by=cases:section_id&group_order=asc&group_id=229043 Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

  1. Go to New dot and enter expensifail account with 2FA enabled
  2. Navigate to email and locate the magic link - change to staging
  3. Open an new tab and navigate to the staging link

    Expected Result:

    2FA required page should be displayed and no loading spinner should appear

Actual Result:

Infinite loading spinner when user navigates to 2FA authentication page

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/43996225/13c37703-397d-46bd-8220-e71e6764ae77

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @slafortune
melvin-bot[bot] commented 5 months ago

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 5 months ago

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 5 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
kavimuru commented 5 months ago

@MonilBhavsar FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

MonilBhavsar commented 5 months ago

Commented on the suspected PR https://github.com/Expensify/App/pull/40177

parasharrajat commented 5 months ago

Let me check.

mountiny commented 5 months ago

@MonilBhavsar Cn you please try to revert that PR and test on it? We should CP the revert if that is the case, thanks!

bernhardoj commented 5 months ago

I already have the fix, going to open up the PR in a moment.

MonilBhavsar commented 5 months ago

Okay thanks! I'll put revert PR on hold then

mountiny commented 5 months ago

Thanks for help Monil

parasharrajat commented 5 months ago

Ping me when ready.

bernhardoj commented 5 months ago

PR is up

cc: @parasharrajat

parasharrajat commented 5 months ago

@MonilBhavsar Please close this issue when confirmed that it is fixed.

parasharrajat commented 5 months ago

@bernhardoj Can you please update the PR to include changes from old PR?

MonilBhavsar commented 5 months ago

Fixed on staging

Screenshot 2024-04-23 at 9 32 48 PM
melvin-bot[bot] commented 4 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 4 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.77-11 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-06. :confetti_ball:

melvin-bot[bot] commented 4 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: