Closed dukenv0307 closed 1 week ago
@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
Looks pretty good from a design perspective.
@Santhosh-Sellavel Friendly bump.
Sorry got lost of tracking as this was not assigned to me/
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.@dukenv0307 can you make those quick commend edits i suggested, then we can get this merged? 🙏
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
Details
Fix receipt preview in confirmation page
Fixed Issues
$ https://github.com/Expensify/App/issues/34120 PROPOSAL: none
Tests
Offline tests
Same as above
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/129500732/6fa78d32-a5dc-42b6-beaf-3170532d019aAndroid: mWeb Chrome
https://github.com/Expensify/App/assets/129500732/48415d16-4f0f-4879-9a8c-91adb999d6c3iOS: Native
https://github.com/Expensify/App/assets/129500732/5e974e0b-4022-492a-a9bb-41885b77dc51iOS: mWeb Safari
https://github.com/Expensify/App/assets/129500732/ec0e1b42-039e-4176-a02b-7d2a7219910bMacOS: Chrome / Safari
https://github.com/Expensify/App/assets/129500732/613ec3eb-ecef-4757-8675-4423109293fdMacOS: Desktop
https://github.com/Expensify/App/assets/129500732/8c141fa0-42bc-4a06-bf71-e64d0c087ff2