[HOLD for payment 2024-06-05][$250] Add Fullstory lib

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.55k stars 2.9k forks source link

[HOLD for payment 2024-06-05][$250] Add Fullstory lib #40784

Closed danieldoglas closed 5 months ago

danieldoglas commented 6 months ago

Parent tracking issue

Placeholder app issue so we can assign open source contributors/reviewers on Implementing Fullstory

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019a2954cbe99d41e6
Upwork Job ID: 1782752092104155136
Last Price Increase: 2024-04-23

Issue Owner

Current Issue Owner: @mallenexpensify

melvin-bot[bot] commented 6 months ago

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

LCOleksii commented 6 months ago

Support of the Fullstory was implemented by:

Adding integration of Fullstory React-Native plugin (IOS, Android)
Adding Fullstory's Annotate React plugin (Mobile, Web)

Separate library activation for Web, Desktop(Hybrid Web) should be done by applying related GTM changes: https://help.fullstory.com/hc/en-us/articles/360020828293-Google-Tag-Manager-GTM

melvin-bot[bot] commented 6 months ago

📣 @LCOleksii! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:
```
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
```

melvin-bot[bot] commented 6 months ago

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

ishpaul777 commented 6 months ago

👋 hello, i'll be reviewing the PR for this

melvin-bot[bot] commented 6 months ago

Job added to Upwork: https://www.upwork.com/jobs/~019a2954cbe99d41e6

melvin-bot[bot] commented 6 months ago

Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

danieldoglas commented 6 months ago

Removing help wanted, this was already worked on.

mananjadhav commented 6 months ago

As per this message, uploading the crash log. Reverting PRs for this issue fixes this issue (App crash on video upload).

fullstory-video-crash.txt

melvin-bot[bot] commented 6 months ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 6 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 6 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.65-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/40894

If no regressions arise, payment will be issued on 2024-05-02. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@LCOleksii requires payment (Needs manual offer from BZ)
@ishpaul777 requires payment (Needs manual offer from BZ)

danieldoglas commented 6 months ago

This PR was reverted - WIP on fixing the issues found.

melvin-bot[bot] commented 6 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.66-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/40894

If no regressions arise, payment will be issued on 2024-05-03. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@LCOleksii requires payment (Needs manual offer from BZ)
@ishpaul777 requires payment (Needs manual offer from BZ)

ishpaul777 commented 6 months ago

any update on this @danieldoglas

danieldoglas commented 6 months ago

This was reverted @LCOleksii is working in a new branch again!

ishpaul777 commented 6 months ago

@LCOleksii Any updates? do we have a draft PR

danieldoglas commented 6 months ago

@ishpaul777 assigned you to the new PR today!

mallenexpensify commented 5 months ago

PR is actively being worked on (as of 2 hours ago)

https://github.com/Expensify/App/pull/42046#issuecomment-2123580321

melvin-bot[bot] commented 5 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.76-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/42046

If no regressions arise, payment will be issued on 2024-06-05. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@LCOleksii requires payment (Needs manual offer from BZ)
@ishpaul777 requires payment (Needs manual offer from BZ)

melvin-bot[bot] commented 5 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.77-11 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/42046

If no regressions arise, payment will be issued on 2024-06-06. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@LCOleksii requires payment (Needs manual offer from BZ)
@ishpaul777 requires payment (Needs manual offer from BZ)

mallenexpensify commented 5 months ago

Payment due tomorrow

ishpaul777 commented 5 months ago

@mallenexpensify I'll be paid in this issue https://github.com/Expensify/App/issues/40809

melvin-bot[bot] commented 5 months ago

Payment Summary

Upwork Job

ROLE: @LCOleksii paid $(AMOUNT) via Upwork (LINK)
ROLE: @ishpaul777 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@mallenexpensify)

[ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
[ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1782752092104155136/hired)
[ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
[ ] I have verified the payment summary above is correct

mallenexpensify commented 5 months ago

Thanks @ishpaul777 , def a strange one with their being two parent issues for the PR.
@LCOleksii are you due payment here?

danieldoglas commented 5 months ago

@LCOleksii is not due payment on this one @mallenexpensify !

mallenexpensify commented 5 months ago

K, sounds like this can be close then. Thx all