search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.99k stars 2.5k forks source link

New tax rate empty state has incorrect label sizes #40813

Open luacmartins opened 3 weeks ago

luacmartins commented 3 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: Reproducible in staging?: Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

Action Performed:

  1. Navigate to Workspace > Taxes > Add rate
  2. Verify that the input labels have incorrect font size of 13px

Expected Result:

Input labels should have font size of 15px

Actual Result:

Input labels should have font size of 13px

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

IMG_9563

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0165be538517a8973a
  • Upwork Job ID: 1782835092067209216
  • Last Price Increase: 2024-04-23
Issue OwnerCurrent Issue Owner: @shawnborton
MahmudjonToraqulov commented 3 weeks ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

New tax rate empty state has incorrect label sizes

What is the root cause of that problem?

We should change font-size here

What changes do you think we should make in order to solve the problem?

We should change font-size here

What alternative solutions did you explore? (Optional)

N/A

Result

melvin-bot[bot] commented 3 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~0165be538517a8973a

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

luacmartins commented 3 weeks ago

Thanks for the proposal @MahmudjonToraqulov, but we're handling this issue internally!

MahmudjonToraqulov commented 3 weeks ago

Ok, sorry.

luacmartins commented 3 weeks ago

@shawnborton did you get a chance to look into this one yet?

shawnborton commented 3 weeks ago

Not yet!

shawnborton commented 2 weeks ago

Not overdue, hoping to look at it this week!

luacmartins commented 2 weeks ago

Shawn will be working on this one!

shawnborton commented 1 week ago

Sorry! Still on my plate, just haven't looked into it yet

melvin-bot[bot] commented 1 week ago

@shawnborton, @luacmartins, @rushatgabhane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

shawnborton commented 5 days ago

Still on my plate

shawnborton commented 4 days ago

@luacmartins I think I'm going to need some help with this one!

It looks like we have a component called MenuItemWithTopDescription which seems to have the correct label behavior. But for tax rates, it's using InputWrapper which has some different styles. Anyways, let's plan to look at this during our next mentor sync.

luacmartins commented 4 days ago

@shawnborton you're close! If you look into InputWrapper, we pass an InputComponent prop to it, which is ultimately the input component we render. For the Name field, we are passing TextPicker. Perhaps we can take a look at the styles TextPicker is using?

melvin-bot[bot] commented 1 day ago

@shawnborton, @luacmartins, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!