Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.97k stars 2.48k forks source link

Held expenses show a permanently highlighted row #40830

Closed m-natarajan closed 1 week ago

m-natarajan commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.64-3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @JmillsExpensify Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713889780388119

Action Performed:

  1. Go to any report with submitted expenses
  2. Click on an individual expense
  3. In the three dot overflow menu (top right), choose Hold request

Expected Result:

The expense preview row is permanently highlighted

Actual Result:

The expense preview row shouldn’t be highlighted at all

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence CleanShot 2024-04-23 at 10 22 50@2x

https://github.com/Expensify/App/assets/38435837/99184e70-7f2b-4e35-bf63-bc3aaa66b2b8

View all open jobs on GitHub

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

gijoe0295 commented 1 week ago

I think this is expected in comment linking feature. When you pressed the parent report link in header, it would highlight the parent report action which is the money request preview here.

slafortune commented 1 week ago

Thanks @gijoe0295 , Yes - I agree with you!