Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

2.97k stars 2.48k forks source link

[$250] [Held request] Held expense button includes the word expense #40831

Open m-natarajan opened 1 week ago

m-natarajan commented 1 week ago

Issue Owner

Current Issue Owner: @rushatgabhane

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

ZhenjaHorbach commented 1 week ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Held expense button includes the word expense

What is the root cause of that problem?

The main problem with issue is that we use Hold expense for translate

https://github.com/Expensify/App/blob/6b18ee91e8f7e498096b1ce04027a830f118ad12/src/languages/en.ts#L714

What changes do you think we should make in order to solve the problem?

To fix this issue we can use hold instead holdExpense

https://github.com/Expensify/App/blob/6b18ee91e8f7e498096b1ce04027a830f118ad12/src/languages/en.ts#L713

For MoneyRequestHeader

https://github.com/Expensify/App/blob/6b18ee91e8f7e498096b1ce04027a830f118ad12/src/components/MoneyRequestHeader.tsx#L129-L136

Actually we can update holdExpense translate But in this case we need to create new translates for places where we use this text

What alternative solutions did you explore? (Optional)

Nodebrute commented 1 week ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Held expense button includes the word expense

What is the root cause of that problem?

We are using hold expense in en.ts file https://github.com/Expensify/App/blob/6b18ee91e8f7e498096b1ce04027a830f118ad12/src/languages/en.ts#L714-L715

What changes do you think we should make in order to solve the problem?

We can change these transalations to hold/unhold and remove expense from here. https://github.com/Expensify/App/blob/6b18ee91e8f7e498096b1ce04027a830f118ad12/src/languages/en.ts#L714-L715 We should also update spanish translation

What alternative solutions did you explore? (Optional)

Or we could define new variables specifically for hold/unhold to be used in scenarios where we just want to show hold/unhold

alexpensify commented 1 week ago

This one is on my testing list, I should have an update soon.

alexpensify commented 6 days ago

No update yet, I've been focused on other GHs.

alexpensify commented 3 days ago

I've tried testing and unable to submit an expense in a test account. My other account doesn't have the hold option, so I reached out in Slack to clarify.

melvin-bot[bot] commented 3 days ago

Job added to Upwork: https://www.upwork.com/jobs/~0176380086c55565e5

melvin-bot[bot] commented 3 days ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

alexpensify commented 3 days ago

@rushatgabhane can you please confirm if one of the proposals will fix this issue? Thanks!

rushatgabhane commented 3 days ago

yes @ZhenjaHorbach's proposal would fix the issue - https://github.com/Expensify/App/issues/40831#issuecomment-2073500307

🎀👀🎀

melvin-bot[bot] commented 3 days ago

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

ZhenjaHorbach commented 3 days ago

It’s strange that the offer was not sent automatically But anyway PR will be ready tomorrow

alexpensify commented 2 days ago

Heads up, I will be offline until Tuesday, May 7, 2024, and will not actively watch over this GitHub during that period.

If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks!