Held expense shows no indication that it’s held in the header

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.64-3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @JmillsExpensify Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713889940519339

Action Performed:

1. Go to any report with submitted expenses
2. Click on an individual expense
3. In the three dot overflow menu (top right), choose Hold request

Expected Result:

Held expenses should indicate that they are held in the header

Actual Result:

No indication in the header. I’m only able to tell by the comment

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[godofoutcasts94]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Held expense shows no indication that it’s held in the header

What is the root cause of that problem?

For the Hold Request Header here :

the header doesn't indicate if the request is Held or Unheld.

What changes do you think we should make in order to solve the problem?

I think we can edit the Hold Request Header Text i.e. after this text - This expense was put on hold. Review the comments for next steps., we can add something like (Held this expense)

What alternative solutions did you explore? (Optional)

Alternatively, here :

in place of Hold, we can add Held or Unheld depending upon the request is Held or Unheld

[godofoutcasts94]

@shawnborton, Please let me know what design ideas do you have ?

[shawnborton]

I think this is a dupe... let me find it. cc @NikkiWines

[shawnborton]

I think this is the existing issue: https://github.com/Expensify/App/issues/39989

cc @trjExpensify @dragnoir

Let's try to get that issue's PR merged soon. Thanks!