Closed hayata-suenaga closed 3 days ago
@c3024 @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
Assigned @s77rt as they have the context behind this PR
Shouldn't this be handled in the BE? i.e. set policy.areTagsEnabled
and policy.areCategoriesEnabled
to true when user setups a connection?
Shouldn't this be handled in the BE? i.e. set policy.areTagsEnabled and policy.areCategoriesEnabled to true when user setups a connection?
The backend PR to enable these are being worked on / was merged. closing this 👍
… exists
Details
When there is an accounting connection, display the toggle buttons for the Categories and Tags features in the active state.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/387834#issuecomment-2063550218 PROPOSAL: N/A
Tests / QA Steps
Offline tests
N/A
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop