Open luacmartins opened 1 week ago
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External
)
Triggered auto assignment to @MitchExpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
dibs
Create automated tests for Workspace Tags page
We don't have automation test for commands in Workspace Tags page
tests/actions
for commands test like WorkspaceTagsTest
SetPolicyRequiresTag
we will call Policy.setPolicyRequiresTag
functionBuild the test case based on all possible cases the input param of the function that will call the API command can have. After calling the API, get the updated data in Onyx and check if it's correct or not based on the expected output data with the given input param of the test case that we pass to the command function.
To write the test for API commands, we can do the same way in other tests like IOUTest
NA
Updated proposal to detail how can we define the test case.
Current assignee @luacmartins is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.
Job added to Upwork: https://www.upwork.com/jobs/~01aeec6fe63684bff5
Current assignee @eh2077 is eligible for the External assigner, not assigning anyone new.
📣 @eh2077 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻 Keep in mind: Code of Conduct | Contributing 📖
@eh2077 The PR is here.
Problem
New API commands introduced as part of the Simplified Collect project don't have automated tests, which can lead to bugs and unexpected behavior when these commands are updated.
Solution
Add automated tests for the commands below:
Upwork Automation - Do Not Edit