Closed allroundexperts closed 1 week ago
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube: | Android :robot: | iOS :apple: |
---|---|---|
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/40840/index.html | https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/40840/index.html | |
Desktop :computer: | Web :spider_web: | |
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/40840/NewExpensify.dmg | https://40840.pr-testing.expensify.com | |
:eyes: View the workflow run that generated this build :eyes:
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.@thienlnam Do not merge until https://github.com/Expensify/App/pull/40840#discussion_r1578695036 has been addressed, as it will create a workspace for Submit it to someone
flow, which is not desired at all.
@thienlnam You are clear to merge now. :shipit:
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.67-0 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.67-7 🚀
platform | result |
---|---|
🤖 android 🤖 | failure ❌ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.67-7 🚀
platform | result |
---|---|
🤖 android 🤖 | failure ❌ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/40668 PROPOSAL: N/A
Tests
Categorize
option.Share with accountant
whisperOffline tests
QA Steps
Categorize
option.Share with accountant
whisperPR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Having issues with my Android build.Android: mWeb Chrome
https://github.com/Expensify/App/assets/30054992/40968f10-a580-4908-8da6-d2aef00aa54ciOS: Native
https://github.com/Expensify/App/assets/30054992/8c3a5e25-300e-4ab4-ad79-5ab3f4914ffeiOS: mWeb Safari
https://github.com/Expensify/App/assets/30054992/64ffeed3-45e7-498d-9f33-eae3921171caMacOS: Chrome / Safari
https://github.com/Expensify/App/assets/30054992/0640a9ae-0e12-4d6f-aae3-39827ae3da4dMacOS: Desktop
https://github.com/Expensify/App/assets/30054992/95a7b1e7-d2be-40fd-a73f-9f2dbc6d5bed