Open nkdengineer opened 1 week ago
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@nkdengineer Please fix conflicts and can you summarize what you have done in this PR?
This PR will create a new route:
ATTACHMENTS: {
route: 'attachment',
getRoute: (reportID: string, type: ValueOf<typeof CONST.ATTACHMENT_TYPE>, url: string, accountID?: number) =>
`attachment?source=${encodeURIComponent(url)}&type=${type}${reportID ? `&reportID=${reportID}` : ''}${accountID ? `&accountID=${accountID}` : ''}` as const,
that can be used in report attachments, note attachments and any type of attachments in the future
@shubham1206agra Pls help review the PR when you have a chance. Thanks
@nkdengineer Please merge main here.
Details
Fixed Issues
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/161821005/38e84cb4-8b29-45d0-8371-8b30eaaa4e62Android: mWeb Chrome
https://github.com/Expensify/App/assets/161821005/ea3a43b3-2377-4051-9f75-070aef7b8030iOS: Native
https://github.com/Expensify/App/assets/161821005/c40982d9-7a1d-4aec-91d6-68bbce2fff36iOS: mWeb Safari
https://github.com/Expensify/App/assets/161821005/e69e828a-2764-466e-98ad-41e8c0cccb7dMacOS: Chrome / Safari
https://github.com/Expensify/App/assets/161821005/4ee7f384-582a-415f-a778-b6fbb0067a7fMacOS: Desktop
https://github.com/Expensify/App/assets/161821005/dec839b2-17c5-4d82-92fe-58fd0d3ce940