Closed strepanier03 closed 6 days ago
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
A preview of your ExpensifyHelp changes have been deployed to https://2d08a31c.helpdot.pages.dev ⚡️
A preview of your ExpensifyHelp changes have been deployed to https://2d08a31c.helpdot.pages.dev/ ⚡️
Looks good, the change is as expected.
@monilbhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
🎯 @rushatgabhane, thanks for reviewing and testing this PR! 🎉
An E/App issue has been created to issue payment here: https://github.com/Expensify/App/issues/41159.
🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.67-7 🚀
platform | result |
---|---|
🤖 android 🤖 | failure ❌ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.68-0 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | failure ❌ |
🕸 web 🕸 | success ✅ |
🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.67-7 🚀
platform | result |
---|---|
🤖 android 🤖 | failure ❌ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.68-3 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
Updated the case of the title.
https://github.com/Expensify/Expensify/issues/381301#issuecomment-2021376947
Details
Fixed Issues
$ PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop