Closed bernhardoj closed 1 week ago
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!
@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
I'm having problem with Android
FAILURE: Build failed with an exception. * What went wrong:
Execution failed for task ':app:configureCMakeDebug[arm64-v8a]'.
> [CXX1409] /Users/bernhardoj/Documents/dev/freelance-temp/Expensify/android/app/.cxx/Debug/4g2e461q/arm64-v8a/android_gradle_build.json developmentDebug|arm64-v8a : expected buildFiles file '/Users/bernhardoj/Documents/dev/freelance-temp/Expensify/node_modules/@react-native-async-storage/async-storage/android/build/generated/source/codegen/jni/CMakeLists.txt' to exist
Design-wise this looks good. Can you show me what this looks like if the error message is 2 lines long, as well as 3 lines long? Thanks!
I'm having problem with Android
FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':app:configureCMakeDebug[arm64-v8a]'. > [CXX1409] /Users/bernhardoj/Documents/dev/freelance-temp/Expensify/android/app/.cxx/Debug/4g2e461q/arm64-v8a/android_gradle_build.json developmentDebug|arm64-v8a : expected buildFiles file '/Users/bernhardoj/Documents/dev/freelance-temp/Expensify/node_modules/@react-native-async-storage/async-storage/android/build/generated/source/codegen/jni/CMakeLists.txt' to exist
I faced the same and the removal of folder .cxx inside android/app and rebuild the app worked for me.
@shawnborton here is how it looks:
@Pujan92 trying now
Lovely, looks good and thanks for confirming for me!
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.@Pujan92 it works, thanks! I have added the screenshot for android
๐ Deployed to staging by https://github.com/marcaaron in version: 1.4.66-0 ๐
platform | result |
---|---|
๐ค android ๐ค | success โ |
๐ฅ desktop ๐ฅ | failure โ |
๐ iOS ๐ | success โ |
๐ธ web ๐ธ | success โ |
๐ Deployed to staging by https://github.com/marcaaron in version: 1.4.66-0 ๐
platform | result |
---|---|
๐ค android ๐ค | success โ |
๐ฅ desktop ๐ฅ | success โ |
๐ iOS ๐ | success โ |
๐ธ web ๐ธ | success โ |
๐ Deployed to production by https://github.com/mountiny in version: 1.4.66-5 ๐
platform | result |
---|---|
๐ค android ๐ค | success โ |
๐ฅ desktop ๐ฅ | success โ |
๐ iOS ๐ | success โ |
๐ธ web ๐ธ | success โ |
Details
The error message is overflowing from the text input container because the text input container has a max height. This PR fix it.
Fixed Issues
$ https://github.com/Expensify/App/issues/40519 PROPOSAL: https://github.com/Expensify/App/issues/40519#issuecomment-2066160811
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
https://github.com/Expensify/App/assets/50919443/be7fedef-fb7f-44ff-bb6f-cfd4b41f8505iOS: mWeb Safari
https://github.com/Expensify/App/assets/50919443/7a0a9bd6-f40d-44ae-8755-515cbbf00fa4MacOS: Chrome / Safari
MacOS: Desktop