Closed nkdengineer closed 1 week ago
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
Please use Por favor, introduce una hora entre 1 y 12 (por ejemplo, 2:30 PM).
for spanish
@nkdengineer Please ping me when the PR is ready
@DylanDylann this PR is ready for preview.
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.67-0 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.67-7 🚀
platform | result |
---|---|
🤖 android 🤖 | failure ❌ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.67-7 🚀
platform | result |
---|---|
🤖 android 🤖 | failure ❌ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/40495 PROPOSAL: https://github.com/Expensify/App/issues/40495#issuecomment-2065876669
Tests
Please enter a time using the 12-hour clock format
is displayedOffline tests
QA Steps
Please enter a time using the 12-hour clock format
is displayedPR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/161821005/ba38fa33-89d7-4100-8335-4636cab36f03Android: mWeb Chrome
https://github.com/Expensify/App/assets/161821005/a919fddf-f1f8-47d2-9ab1-a94308d42639iOS: Native
https://github.com/Expensify/App/assets/161821005/6223c3c7-367a-42a4-8aae-5e0b84a07dd6iOS: mWeb Safari
https://github.com/Expensify/App/assets/161821005/a5883ea9-1dd4-42d0-8719-a842312f05b5MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/161821005/622391bd-d601-4fa5-b484-0625c6859522MacOS: Desktop
https://github.com/Expensify/App/assets/161821005/a579f66c-6e3d-4b2f-be8a-a73746785d5d