search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.97k stars 2.48k forks source link

[HOLD for payment 2024-05-03] [HOLD for payment 2024-05-02] [$250] Android - Chat - Mention suggestion gets behind other UI components while in edit mode #40854

Closed izarutskaya closed 4 days ago

izarutskaya commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.65-0 Reproducible in staging?: Y Reproducible in production?: N Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

  1. Open new expensify app
  2. Open a report
  3. Send a message
  4. Edit the message
  5. Type "@" to open the suggestion pop up

Expected Result:

The suggestion pop up should be on top of other UI components in the report page

Actual Result:

The suggestion pop up gets behind other UI components from the report page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/f67dc02c-80fe-4bf3-8d90-9280326ce74b

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013c924587ad4f6a8f
  • Upwork Job ID: 1783066631827873792
  • Last Price Increase: 2024-04-24
melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 1 week ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
izarutskaya commented 1 week ago

@isabelastisser I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

izarutskaya commented 1 week ago

We think this issue might be related to the #collect project.

izarutskaya commented 1 week ago

Production

https://github.com/Expensify/App/assets/115492554/c9aa74db-d434-40c3-a6ee-e2c7500d9d75

Julesssss commented 1 week ago

I'm on the fence about this being a blocker. It works on web, and on Android I simply can't open the @ menu, instead of it rendering behind other UI. I'm going to drop it as a blocker, but ensure we fix this quickly.

Web

Screenshot 2024-04-24 at 10 29 04

Android Screenshot_20240424-102758

melvin-bot[bot] commented 1 week ago

Job added to Upwork: https://www.upwork.com/jobs/~013c924587ad4f6a8f

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

Julesssss commented 1 week ago

This issue sounds like a possible cause.

dukenv0307 commented 1 week ago

@Julesssss When we test the suggestion for edit composer in the PR, it doesn't happen this bug. I can't run Android on the latest main so I'm not sure if it comes from my PR.

izarutskaya commented 1 week ago

Suggestion list cannot be selected in iOS, but is not hidden behind content like Android. Check please this video. Thanks

https://github.com/Expensify/App/assets/115492554/767d1749-ecfd-4afa-a8a3-670c39ddbdd2

mountiny commented 1 week ago

I am reverting the PR which most likely contributed to this bug https://github.com/Expensify/App/pull/40865 @dukenv0307 please note this issue so you can test for it in v2. thanks

mountiny commented 1 week ago

Lets retest this after the CP of the revert is done and if this is not repro anymore on 65-2 lets assign @dukenv0307 so they can handle it in the next PR

melvin-bot[bot] commented 1 week ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.65-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-02. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 1 week ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

melvin-bot[bot] commented 1 week ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.66-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-03. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 1 week ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

isabelastisser commented 5 days ago

Bump @abdulrahuman5196 to complete the BZ list. Thanks!

abdulrahuman5196 commented 4 days ago

@isabelastisser I think we can close this issue. No payment required here. Seems this was a regression issue and the original PR was reverted.

isabelastisser commented 4 days ago

Thanks for the update, @abdulrahuman5196! Closing.