search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.97k stars 2.48k forks source link

[HOLD for payment 2024-05-03] [HOLD for payment 2024-05-02] Chat - Unable to dismiss comment edit with ESC key #40856

Closed izarutskaya closed 1 week ago

izarutskaya commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.65-0 Reproducible in staging?: Y Reproducible in production?: N Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to chat.
  3. Send a message.
  4. Right click on the message > Edit comment.
  5. Hit ESC key.

Expected Result:

Comment edit will be dismissed.

Actual Result:

Unable to dismiss comment edit with ESC key.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/da422b7f-0196-4547-ac13-3f84852dd843

View all open jobs on GitHub

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 1 week ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
izarutskaya commented 1 week ago

@twisterdotcom I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

izarutskaya commented 1 week ago

We think this issue might be related to the #vip-vsb.

izarutskaya commented 1 week ago

Production

https://github.com/Expensify/App/assets/115492554/895e395b-225d-42e4-a601-95862caac9bb

mountiny commented 1 week ago

@dukenv0307 Might be related to this https://github.com/Expensify/App/pull/35226 PR

twisterdotcom commented 1 week ago

Easily recreatable. Will wait for @dukenv0307 to chime in before we slap External on this.

mountiny commented 1 week ago

I can repro on main

mountiny commented 1 week ago

Confirmed the revert fixed this issue https://github.com/Expensify/App/pull/40865 I prefer to proceed with the re vert as it seems like that PR has been linked to couple other blockers

dukenv0307 commented 1 week ago

@mountiny I agree that was caused by the code that I added here.

https://github.com/Expensify/App/blob/eebd47cbd01a1ac62667f03a7eac96cae213d1c8/src/pages/home/report/ReportActionItemMessageEdit.tsx#L377

But the current RCA is triggerHotkeyActions function here returns wrong here. It always returns true if the key is ESC and then breaks the logic to close the edit composer below.

To fix this issue we should return false if we do nothing on the suggestion. I can create a PR to fix this as a follow-up of my PR.

mountiny commented 1 week ago

@dukenv0307 I can see there is multiple regressions linked, in order to move deploy forwards, I prefer revert and you can add these fixes and test it thoroughly in second try. Its not a critical feature we need out in release 1

dukenv0307 commented 1 week ago

Thanks.

mountiny commented 1 week ago

revert PR being CPed, closing as we will validate the PR

melvin-bot[bot] commented 1 week ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.65-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-02. :confetti_ball:

melvin-bot[bot] commented 1 week ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

melvin-bot[bot] commented 1 week ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.66-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-03. :confetti_ball:

melvin-bot[bot] commented 1 week ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: