"Group/room name" field out of Settings and into Report

[dragnoir]

Details

This PR move the Group Chat "Group/Room name" field out of Settings and into Report Details

Fixed Issues

$ https://github.com/Expensify/App/issues/40262 PROPOSAL: https://github.com/Expensify/App/issues/40262#issuecomment-2058957823

Tests

1. Open a group report or a room
2. click on the header to open the details page
3. check if there's a new menu item for the Group/Room name

• [x] Verify that no errors appear in the JS console

Offline tests

QA Steps

1. Open a group report or a room
2. click on the header to open the details page
3. check if there's a new menu item for the Group/Room name

• [x] Verify that no errors appear in the JS console

PR Author Checklist

• [x] I linked the correct issue in the ### Fixed Issues section above
• [x] I wrote clear testing steps that cover the changes made in this PR
  • [x] I added steps for local testing in the Tests section
  • [x] I added steps for the expected offline behavior in the Offline steps section
  • [x] I added steps for Staging and/or Production testing in the QA steps section
  • [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• [x] I included screenshots or videos for tests on all platforms
• [x] I ran the tests on all platforms & verified they passed on:
  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop
• [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• [x] I followed proper code patterns (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I followed the guidelines as stated in the Review Guidelines
• [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• [x] I verified that if a function's arguments changed that all usages have also been updated correctly
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • [x] I verified that all the inputs inside a form are aligned with each other.
  • [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native


Android: mWeb Chrome


iOS: Native


iOS: mWeb Safari


MacOS: Chrome / Safari


MacOS: Desktop


[melvin-bot[bot]]

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[dragnoir]

Some screenshots:

Groupe:

Room:

Admin room:

Deprecated group:

Long workspace name:

Long group name:

long room name:

[dragnoir]

Archived room:

[dragnoir]

@shawnborton you may want to review this!

[shawnborton]

For archived rooms, I think they should look identical to room names that can't be edited, like so:

No need to create a separate design style for archived rooms in my opinion. cc @Expensify/design for vis.

Otherwise will spin up a test build now.

[github-actions[bot]]

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:	Android :robot:	iOS :apple:
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/40858/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/40858/index.html
Desktop :computer:	Web :spider_web:
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/40858/NewExpensify.dmg	https://40858.pr-testing.expensify.com

---

:eyes: View the workflow run that generated this build :eyes:

[dannymcclain]

Test build is looking pretty good!

[shawnborton]

Testing now and reporting a few things:

For workspace chats, we should also update the way we display the name:

From our mocks:

Note that we want to update the workspace room avatar, but I think we can handle that in a different PR.

[dragnoir]

For archived rooms, I think they should look identical to room names that can't be edited

Archived rooms don't belong to Workspaces. Do I have just to remove the part where the workspace is? "In....."

[shawnborton]

Archived rooms are indeed on workspaces, for example:

[dragnoir]

For workspace chats, we should also update the way we display the nam

for this, updates as we have on groups?

Workspace name: My WorkspaceName

[shawnborton]

So the thing with workspace rooms is that they have a different title depending if the Submitter or Admin is viewing them.

Submitter sees:

Admin currently sees:

So maybe something like this makes sense?

Thoughts @Expensify/design?

[dragnoir]

I think the "Workspace" label will be double, top and bottom

[shawnborton]

Yeah, that's why I am suggesting we just reuse "Room name" - see my mock above

[shawnborton]

Also I don't think you can rename those, so there wouldn't be an arrow on the right.

[dannymcclain]

Looks good to me Shawn & I agree.

And here's a quick mock of an archived room for reference. Look right to you @shawnborton?

[shawnborton]

Love it, that looks perfect to me.

[dubielzyk-expensify]

That looks great from my end as well

[dragnoir]

@shawnborton any idea how can I simulate the "Submitter View" for a workspace?

Create a workspace by another user then submit a report to it by my account?

[shawnborton]

Yup, create a workspace as an "Admin" and then invite an "Employee" to your workspace. Then from the employee's perspective, submit an expense to the workspace.

[dragnoir]

Admin View

Submitter View

[shawnborton]

I think that's looking good. cc @JmillsExpensify - just letting you know we're getting a head start on the room name styles here, though I know we might have more changes coming with your doc.

[dragnoir]

@shawnborton what about invoices? 🤔

@eVoloshchak pls if we can close this ASAP, daily updates and conflicts 😁

[shawnborton]

In that case, I think we can drop the "In Invoices" and just say "Invoices"

Also in talking with @JmillsExpensify, I think we want it to say "Name" instead of "Room name" for workspace chats and invoice chats.