search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.97k stars 2.48k forks source link

Chat - User mention is not highlighted as mention when mentioning someone in edited comment #40861

Open izarutskaya opened 1 week ago

izarutskaya commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.65-0 Reproducible in staging?: Y Reproducible in production?: N Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to chat.
  3. Send a message.
  4. Right click on the message > Edit comment.
  5. Type @.
  6. Select a user from the suggestion list.
  7. Save the edit.

Expected Result:

The user mention in the edited message will be highlighted as mention.

Actual Result:

The user mention in the edited message is not highlighted as mention.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/65ba9e54-2158-4f57-90ea-f5708aa63bd8

View all open jobs on GitHub

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 1 week ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
izarutskaya commented 1 week ago

@adelekennedy I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

izarutskaya commented 1 week ago

We think this issue might be related to the #vip-vsb.

izarutskaya commented 1 week ago

Production image (10)

mountiny commented 1 week ago

This is technically not in production so its not a blocker but I agree this should be addressed in the PR

mountiny commented 1 week ago

We are going to revert this PR https://github.com/Expensify/App/pull/35226 and @dukenv0307 can you please work on implementing this in there too as I think it should be part of the initial implementation (it looks weird when you choose the mention and its not saved that way)