Chat - Suggestion list does not appear below composer when it is near chat header

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

2.97k stars 2.48k forks source link

Chat - Suggestion list does not appear below composer when it is near chat header #40864

Open izarutskaya opened 1 week ago

izarutskaya commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.65-0 Reproducible in staging?: Y Reproducible in production?: N Found when validating PR : https://github.com/Expensify/App/pull/35226 Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

Open the App
Go to chat.
Send a long list of messages.
Right click on the message near the chat header > Edit comment.
Type @.

Expected Result:

The mention suggestion list will appear under the edit compoer (mweb behavior).

Actual Result:

The mention suggestion list appears above the edit compoer which now appears behind the header.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/d9309dd4-1ba0-4645-a3a1-fd9dd82dcaff

View all open jobs on GitHub

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 1 week ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

izarutskaya commented 1 week ago

@joekaufmanexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

izarutskaya commented 1 week ago

We think this issue might be related to the #vip-vsb.

izarutskaya commented 1 week ago

Production

Screenshot_2024-04-24-13-47-14-41_4f9154176b47c00da84e32064abf1c48

mountiny commented 1 week ago

@dukenv0307 @eVoloshchak @stitesExpensify can you please check this out

dukenv0307 commented 1 week ago

@mountiny Since this is a new feature, I can fix this issue as a part of my PR. We can remove the deploy blocker here. WDYT?

mountiny commented 1 week ago

Since there was couple other things raised for this PR, in order to have smooth deploys ahead of Release 1 period, I will revert, please add this to the scope of you version2 PR

dukenv0307 commented 1 week ago

Sure.

mountiny commented 1 week ago

Adding @dukenv0307 so we dont forget to fix this in the new PR

melvin-bot[bot] commented 1 week ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.65-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/40865

If no regressions arise, payment will be issued on 2024-05-02. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@dukenv0307 requires payment (Needs manual offer from BZ)

melvin-bot[bot] commented 1 week ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@dukenv0307] Determine if we should create a regression test for this bug.
[ ] [@dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot[bot] commented 1 week ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.66-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/40865

If no regressions arise, payment will be issued on 2024-05-03. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@dukenv0307 requires payment (Needs manual offer from BZ)

melvin-bot[bot] commented 1 week ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@dukenv0307] Determine if we should create a regression test for this bug.
[ ] [@dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Beamanator commented 6 days ago

So if I'm clear here, we're planning to kinda "not do anything" with this issue, but @dukenv0307 is working on fixing this bug in https://github.com/Expensify/App/pull/41071?

joekaufmanexpensify commented 6 days ago

That's my understanding! If so, perhaps we can close this out, if it's not really needed?

Beamanator commented 5 days ago

I thinkkkk yes!? As long as it's clear in https://github.com/Expensify/App/pull/41071 & the related issue that this bug needs to get solved 👍