Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.97k stars 2.48k forks source link

[CP Staging] Revert "Implement suggestion for edit composer" #40865

Closed mountiny closed 1 week ago

mountiny commented 1 week ago

Reverts Expensify/App#35226

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/40856 $ https://github.com/Expensify/App/issues/40864 $ https://github.com/Expensify/App/issues/40854

Tests

mountiny commented 1 week ago

Running a test build

melvin-bot[bot] commented 1 week ago

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions[bot] commented 1 week ago
:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube: Android :robot: iOS :apple:
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/40865/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/40865/index.html
Android iOS
Desktop :computer: Web :spider_web:
❌ FAILED ❌ https://40865.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed Web

:eyes: View the workflow run that generated this build :eyes:

danieldoglas commented 1 week ago

Straight revert, not doing the checklist

melvin-bot[bot] commented 1 week ago

@danieldoglas looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

mountiny commented 1 week ago

Checklistts not required on straight revert

OSBotify commented 1 week ago

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅