Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.97k stars 2.48k forks source link

iOS - Chat - Suggestion list in edit composer is easily dismissed when scrolling down the list #40866

Closed izarutskaya closed 1 week ago

izarutskaya commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.65-0 Reproducible in staging?: Y Reproducible in production?: N Found when validating PR https://github.com/Expensify/App/pull/35226 Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

  1. Launch New Expensify app.
  2. Go to chat.
  3. Send a message.
  4. Right click on the message > Reply in thread.
  5. Right click on the parent message in thread > Edit comment.
  6. Type @.
  7. Scroll down the suggestion list slowly, while keeping the finger within the list.

Expected Result:

The list will not dismiss when scrolling down the list.

Actual Result:

Suggestion list is easily dismissed when scrolling down the list.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/f597764c-d6fc-4069-a007-76df2ee4089a

View all open jobs on GitHub

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 1 week ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
izarutskaya commented 1 week ago

@garrettmknight I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

izarutskaya commented 1 week ago

We think this issue might be related to the #vip-vsb.

dukenv0307 commented 1 week ago

It's expected behavior that we discussed here https://github.com/Expensify/App/pull/35226#issuecomment-1953716072.

mountiny commented 1 week ago

Seems like expected behaviour