Closed rlinoz closed 1 week ago
@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@mananjadhav @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.@pecanoro @rlinoz Does this need C+ review?
@mananjadhav It's a simple change, I can test it, no worries!
@rlinoz I would also have Applause do the steps you listed in Tests with the network tab to make sure it is not being called.
Oh nice, I wasn't sure they did that kind of testing as well, let me update.
Compiling on the phone platforms takes forever, so I am going to merge it since I tested it on desktop and web.
Edit: tested on iOS though
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
π Deployed to staging by https://github.com/pecanoro in version: 1.4.66-0 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | failure β |
π iOS π | success β |
πΈ web πΈ | success β |
π Deployed to staging by https://github.com/pecanoro in version: 1.4.66-0 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
π Deployed to production by https://github.com/mountiny in version: 1.4.66-5 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/390367 PROPOSAL:
Tests
#
and verify that no request is made toSearchForRoomsToMention
and no auto complete widget pops up#
and continue typing until there are less than 5 results, verify that a call toSearchForRoomsToMention
is madeOffline tests
QA Steps
#
and verify that no auto complete widget pops up, also verify that no call toSearchForRoomsToMention
is made in the network tab#
and continue typing to find the room created in the previous step, verify that the room shows up in the auto complete after a while, also verify there are few calls toSearchForRoomsToMention
in the network tabPR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/5201282/68ff7fad-58e3-4bbc-8181-59f774f030b4 https://github.com/Expensify/App/assets/5201282/e26abcc7-743e-4af2-a47e-f271553c6032 https://github.com/Expensify/App/assets/5201282/32273345-83c1-482b-aa8f-4e1cf38485b2MacOS: Desktop