Closed koko57 closed 1 week ago
@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
What is your ETA for the review here? @Ollyws
Will review now.
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
π Deployed to staging by https://github.com/robertjchen in version: 1.4.67-0 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
π Deployed to production by https://github.com/francoisl in version: 1.4.67-7 π
platform | result |
---|---|
π€ android π€ | failure β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
π Deployed to production by https://github.com/francoisl in version: 1.4.67-7 π
platform | result |
---|---|
π€ android π€ | failure β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/40756 $ https://github.com/Expensify/App/issues/40749 PROPOSAL:
Tests
Merchant Error
Amount Error
Offline tests
n/a
QA Steps
Merchant Error
Amount Error
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
having problems with building the project on android nowAndroid: mWeb Chrome
https://github.com/Expensify/App/assets/28020445/6746fed2-ad18-4355-9e05-6d891be7103e https://github.com/Expensify/App/assets/28020445/7e6d67a6-c01f-42f9-a11b-809aedc42398iOS: Native
https://github.com/Expensify/App/assets/28020445/ed3ac6a7-cda0-4718-b503-905c97bb89e1 https://github.com/Expensify/App/assets/28020445/b785e49d-d253-4436-8817-c4e4f38ea1c1iOS: mWeb Safari
https://github.com/Expensify/App/assets/28020445/04d3cdab-b45d-404c-a4d8-aec61a08d438 https://github.com/Expensify/App/assets/28020445/b765be27-4585-45ee-a078-4e4fe0b6c647MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/28020445/4715c31e-4117-4a6f-b3a4-947be0fc7abb https://github.com/Expensify/App/assets/28020445/1cb52609-3f9f-4155-8b8a-097185a7e59aMacOS: Desktop
https://github.com/Expensify/App/assets/28020445/1027722c-0c68-4f27-aa53-24f247114eee