Closed rezkiy37 closed 1 week ago
@dubielzyk-expensify @shubham1206agra One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@rezkiy37 Just confirming here. Do you want me to complete checklist here?
I can handle this
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.I will go ahead so we can include this in the follow up deploy
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.66-0 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | failure ❌ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.66-0 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.66-5 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/38414 PROPOSAL: N/A
Tests
Note: you can run the flow as many times as you want by adding a test button into TestToolMenu.tsx.
Details
```typescriptPurposes with videos
Purposes without videos
Offline tests
Same as "Tests".
QA Steps
Same as "Tests".
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
https://github.com/Expensify/App/assets/57314631/93c60f47-937d-45f1-8b23-7f6764c07556iOS: Native
https://github.com/Expensify/App/assets/57314631/b436cda0-1374-47c5-b3ef-34f745d03f0aiOS: mWeb Safari
https://github.com/Expensify/App/assets/57314631/02050d5e-1d61-4115-804b-6b4db74c9760MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/57314631/d8e646b2-8477-4c01-acdd-d2ecac08f884 https://github.com/Expensify/App/assets/57314631/c129d924-f02c-43e3-a435-1337117d7c4cMacOS: Desktop
https://github.com/Expensify/App/assets/57314631/796dde40-cf39-4dc5-96fb-5a2c1b5c5eae